Coder Social home page Coder Social logo

Comments (1)

jbednar avatar jbednar commented on May 21, 2024

Yes, it would be great to get those new maps. Looks like the names have again changed upstream, and the values have also been truncated to fewer (not more) significant digits, which probably doesn't matter but could conceivably change a color. I'd rather not change any of the existing maps at all, so I'd want to get only the new ones. I've also kept the original naming style for continuity.

I think the steps involved in such a PR would be:

  1. Unpack the new CETperceptual_csv_0_1.zip into assets/CETperceptual_csv_0_1_v3.
  2. If any of the ones in colorcet.m are useful (and not just e.g. stray obsolete versions), make CSVs for them and put them in e.g. assets/colorcet_m_to_csv
  3. Edit assets/CET_to_py.py:
    • Add the new directory(s) to paths
    • Add support for v3 (and colorcet_m) following what's done already for v2 (though it's fairly complicated at first glance!)
    • Add mapping info to mapping, with long names for the short filenames from v3 (not sure where that mapping came from; maybe it's on Peter's website?)
    • Add aliases where appropriate (e.g. wrkb, ymcgy, gouldian, rainbowbr)
  4. Run CET_to_py.py to generate an updated colorcet/__init__.py.
  5. Check the generated colorcet/__init__.py to make sure it didn't mess up any of the existing colormaps and defines the new ones properly, and doesn't somehow get extra copies of all the v1 and v2 maps that are duplicated in v3.
  6. Make a PR with the new CSVs and updated colorcet/__init__.py.

Seems like somehow it didn't need to be this complicated, but I don't see how to simplify it.

from colorcet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.