clone_only strategy fail - panics - not implemented about holochain

[ThetaSinner]

I am nearly done working through the sys_validation workflow which is a priority right now but this is a pretty serious thing to not have working so I'd like to look at this next. @abe-njama for discussion in our meeting later please

[ThetaSinner]

Thanks for raising this @nphias. My preliminary investigation suggests this is indeed not implemented correctly.

So in this test the code relies on all_cells which ends up looking at role_assignments in here https://github.com/holochain/holochain/blob/develop-0.2/crates/holochain/src/conductor/tests/install_app_bundle.rs#L82

Now following what happens with those role assignments
CloneOnly is recognised as needing the ProvisionOnly strategy https://github.com/holochain/holochain/blob/develop-0.2/crates/holochain_types/src/app/app_bundle.rs#L210
That results in role assignments being updated here https://github.com/holochain/holochain/blob/develop-0.2/crates/holochain_types/src/app/app_bundle.rs#L109. But notice the line above, where dnas_to_register is also set
Next, in the conductor it will ask for cells_to_create https://github.com/holochain/holochain/blob/develop-0.2/crates/holochain/src/conductor/conductor.rs#L1389. That is entirely based on dnas_to_register https://github.com/holochain/holochain/blob/develop-0.2/crates/holochain_types/src/app/app_bundle.rs#L297 and NOT the actual role assignments.
Now the conductor goes ahead and runs genesis for those cells https://github.com/holochain/holochain/blob/develop-0.2/crates/holochain/src/conductor/conductor.rs#L1417
Only after genesis succeeds does the conductor check the actual role assignments to report the conductor state https://github.com/holochain/holochain/blob/develop-0.2/crates/holochain/src/conductor/conductor.rs#L1420

[ThetaSinner]

I think I've got a fix for this, just waiting to see that it doesn't break anything else but I think that's reasonably unlikely :)

[ThetaSinner]

This can be back-ported as soon as it's approved and merged so if all goes well it will be in the first 0.2.4 release candidate

[ThetaSinner]

Keeping this open for the backport

[ThetaSinner]

Back-ported in #3121 and will be released with 0.2.4 as planned