[BUG] Signals stop working with extern crate and git dependency about holochain

[nphias]

example here:
https://github.com/nphias/invitations-test

use: npm test

[ThetaSinner]

@nphias do you already have a project/branch with a reproduction that you could share?

[ThetaSinner]

Thank you @nphias, this is on my list to look at

[ThetaSinner]

Confirming the reproduction looks good. Thank you for that!

I'm not sure right now when this will get looked at but it definitely seems worth trying to trace down

[nphias]

problem continues with holochain version 0.1.5

[ThetaSinner]

Okay, I have good news on this because I think I have it figured out. The extern crate vs. 'copy the code' approaches do yield different WASMs which I cannot explain but what I can say is that either way you get the exact same functions exposed and they do the same thing. Maybe somebody who knows more about the details of how Rust code gets transformed into WASM could explain the difference but I don't think it actually matters a great deal here.

What is much more important is that integrity zomes are strictly excluded from signalling. That isn't something I was looking for exactly but it's quite evident from the Holochain code once you dig deep enough trying to trace what the conductor is doing. So that led me to looking at where the signals are being sent from. The invitations zome that does the signalling is being loaded as an integrity zome and the integrity zome isn't being loaded at all.

@nphias Could you update your workdir/dna/dna.yaml to look like this:

---
manifest_version: "1"
name: group
integrity:
  network_seed: ~
  properties: ~
  origin_time: 1669136217555883
  zomes:
    - name: profiles_integrity
      hash: ~
      bundled: "../../target/wasm32-unknown-unknown/release/profiles_integrity.wasm"
      dependencies: ~
    - name: invitations_integrity
      hash: ~
      bundled: "../../target/wasm32-unknown-unknown/release/invitations_integrity.wasm"
      dependencies: ~
coordinator:
  zomes:
    - name: profiles
      bundled: "../../target/wasm32-unknown-unknown/release/profiles.wasm"
      dependencies:
        - name: profiles_integrity
    - name: invitations
      bundled: "../../target/wasm32-unknown-unknown/release/invitations.wasm"
      dependencies:
        - name: invitations_integrity

and re-run the tests? I believe this is enough to address the problem. I am seeing test 4. fail, but it doesn't appear to be related to signals so I'll hold off looking at that unless something else is happening unexpectedly there.

[ThetaSinner]

There is also a small bug here https://github.com/nphias/invitations-test/blob/main/crates/coordinator/invitations/Cargo.toml#L11C1-L11C33

This should read hc_coordinator_zome_invitations = {git = "https://github.com/holochain-open-dev/invitations.git", branch = "crates-only"} I believe? Then the lib contains extern crate hc_coordinator_zome_invitations;

[nphias]

Thanks ThetaSinner,

So it seems it was a problem with my dna.yaml file which i fixed .. mentioning both coordinator and integrity zomes and using correct indentation . The outcome of this enquiry might be that it would be better to have a warning if not all zomes are referenced in the yaml file.. maybe a parser for the yaml.. some useful error/warning messages instead of silent failure

[ThetaSinner]

Thanks @nphias, I've opened #2710 to catch DNA manifest errors which I think can quickly be done with this.

I've also opened an internal ticket to look at rejecting HDK calls from integrity zomes because that can still happen with a valid manifest.