Coder Social home page Coder Social logo

Comments (7)

hofq avatar hofq commented on June 3, 2024

The Official image was not available on the release of my Template.
i can't follow you on how you think it's concerning, since you can see every step of the Build Process in Github.
I will switch it if i have checked the Official Image & Build, probably in the next days.

from docker-templates.

PartyLich avatar PartyLich commented on June 3, 2024

While the build process is visible, my concern is that it is building a fork of the actual repo. At present that fork matches upstream, as I noted. The central issue is extending trust to an additional party. The lesser issue is providing support for users who are not running the main repo's code. It is worth noting that, initially, you've been a great help to those users on unraid making use of your template. Thank you for that!

If a vulnerability/CVE/etc is patched upstream but your personal engagements prevent pulling those changes into the fork in a timely manner, anyone relying on the unraid image is exposed. If you wake up tomorrow and decide you have some nefarious intent, you can modify that fork accordingly. It's happened with npm packages (edit to add: or log4j if you're looking for recency and size). It's happened with browser plugins. I have zero reason to think that's likely with you specifically, but there is precedent.

A downstream user of the unraid CA now has to assign as much trust to you as they have to Actual's maintainer and contributors. If you're not intending any modification, maintaining a fork presents extra work without any benefit. I'm not sure what one would see as advantageous about that, but please share any advantages you see if you're willing to do so.

In terms of supporting a user, I have the option of a) directing them to you, as they arent running main repo or b) comparing your fork each time to see that it still reflects upstream before providing any answer. I'm just a random contributor, I have no official connection to Actual, and thus no obligation to provide help at all; but I'd argue the community works a little better when those that can help decide to do so.

from docker-templates.

hofq avatar hofq commented on June 3, 2024

Hi,
i compared both images and i see no difference.
Thank you for the Notice that an Official Docker Image is now avalible, i should have looked at the official Project more often.

Since Persistent Data was not stored in a separate folder before, i will change the image in a week to prevent data loss

from docker-templates.

hofq avatar hofq commented on June 3, 2024

And, if you have any Unraid-Related Issues, just ping me on Discord in the Conversation. I am Happy to help!

Johannes Walther#4343

from docker-templates.

hofq avatar hofq commented on June 3, 2024

Merged!

from docker-templates.

hofq avatar hofq commented on June 3, 2024

#16

from docker-templates.

PartyLich avatar PartyLich commented on June 3, 2024

from docker-templates.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.