publicUpload does not work about nextcloud-node-client

[hobigo]

Hi kbzowski,
thanks for sharing the bug.

I have fixed the bug and added test 13-3 that covers the bug.

Please try out v1.8.1.

Regards
hobigo

[kbzowski]

Works fine with 1.8.1. Does not work with 1.8.2

[hobigo]

Hi kbzowski,
I did not publish 1.8.2 to npm - 1.8.1 is the latest version
here is an example project.
rgds hobigo

src/index.ts

import Client, {
    Server,
    ICreateShare,
    Folder,
    Share,
} from "nextcloud-node-client";

(async () => {
const client: Client = new Client(
    new Server({url:"https://myServer",basicAuth:{username:"myUser",password:"myPassword"}})
    );
const folder: Folder = await client.createFolder("/my Public Share");
const createShare: ICreateShare = { fileSystemElement: folder, publicUpload: true };

let share: Share;

try {
    share = await client.createShare(createShare);
    console.log(`share created successfully for folder ${folder.name}`);
} catch (e) {
    console.log("error occurred",e)
}

})();

package.json

{
  "name": "ncnc-public-share",
  "version": "1.0.0",
  "description": "test project to create a public share with a nextcloud folder",
  "main": "./dist/index.js",
  "scripts": {
    "build": "tsc",
    "start": "node ./dist/index.js"
  },
   "author": "test",
  "license": "ISC",
  "devDependencies": {
    "@types/node": "^14.0.27",
    "@types/node-fetch": "^2.5.7",
    "typescript": "^3.9.7"
  },
  "dependencies": {
    "nextcloud-node-client": "^1.8.1"
  }
}

tsconfig.json

{
    "compilerOptions": {
        "target": "es2018",
        "module": "commonjs",
        "rootDir": "./src",
        "outDir": "./dist",
        "strict": true,
        "esModuleInterop": true
    },
    "include": [
        "./**/*.ts"
    ],
    "exclude": [
        "node_modules"
    ]
}

npm i
npm run build
npm run start

[kbzowski]

I was almost sure that I saw 1.8.2 in my package.json. My mistake. It works fine with 1.8.1. Issue can be closed.

[hobigo]

I had a commit with that version
If you like the nextcloud-node-client please leave me a star
rgds hobigo