Coder Social home page Coder Social logo

Missing images are not handled about paperoni HOT 2 CLOSED

kxt avatar kxt commented on May 29, 2024
Missing images are not handled

from paperoni.

Comments (2)

hipstermojo avatar hipstermojo commented on May 29, 2024

Hi @kxt, thanks for trying out Paperoni and also investigating the issue you faced. Might I ask for the URL of the website you were testing it on and the version of Paperoni you used on it?
The current version of Paperoni 0.4.0-alpha1 has redirects enabled for downloading images as well as leaving the original URL in place in case it is unable to fetch it. In case you are using the latest version then I will look to fix this bug before the next release which should be on May 24th.

from paperoni.

kxt avatar kxt commented on May 29, 2024

I'm using 0.4.0-alpha1.

I've noticed the bug with multiple pages on substack, eg this one: https://blindsquirrel.substack.com/p/etsy-the-power-of-special . But this already involves the other bug mentioned where the image url gets rewritten to an invalid one, and I haven't yet figured out that one.

To have a clean reproduction, I just created a bogus html file like this:

<html>
<head><title>Test page</title></head>
<body>Hello world! <img src="missing.png"/></body>
</html>

And then served it locally with python: python -mhttp.server

The problem is that this is not a fetch error that the match req.await catches. The error 404 page is a successful fetch containing a content type of text/html, so the error code should be checked.

from paperoni.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.