Invalid BSPTree created during union about hipparchus

[maisonobe]

The issue should be fixed in the git repository.
Note that as the spherical polygons in the test case are very small with respect to the tolerance
(or rather the tolerance is very large with respect to the spherical polygons), the result of the union
operation is now a consistent BSP tree, but is not very accurate. As several points from the two
polygons are too close to each other, they are considered equal, which distorts the result.
This is considered normal.
I agree that the consistency of the tree needed to be fixed.

Thanks for the report, for the analysis, and for the simple test case!

[jerdmanGH]

Thanks for the quick turnaround. Is there a planned release date for 1.4?

[maisonobe]

No release date planned for now, but we could do that.
Do you need a release soon or would a release in the next few months suit your needs?

[jerdmanGH]

I've been playing around with tolerance values to try to determine if there is an "ideal" setting that will fit my use case but keep running into issues. The latest is a "this should never happen" exception that can be reproduced using the code below. I can submit this as a new issue but it may already be fixed by your previous commit. I'm going to put in a check for minimum allowable size for shapes to see if that gets me past this. I'm hopeful that I can find a workaround without the need for an accelerated release.

        S2Point[] s2pA = new S2Point[]{
                new S2Point(new Vector3D(0.1504230736114679, -0.6603084987333554, 0.7357754993377947)),
                new S2Point(new Vector3D(0.15011191112224423, -0.6603400871954631, 0.7358106980616113)),
                new S2Point(new Vector3D(0.15008035620222715, -0.6605195692153062, 0.7356560238085725)),
                new S2Point(new Vector3D(0.1503914563063968, -0.6604879854490165, 0.7356208472763267))
        };
        final SphericalPolygonsSet spsA = new SphericalPolygonsSet(1E-100, s2pA);
        spsA.getSize();

[maisonobe]

Please open a new issue. It is not fixed by the previous commit.