Comments (5)
You are right, checking the value itself is sufficient, and in fact checking the partial derivatives is wrong here: when we cross a zero, there is no reason why the derivatives should be zero. In fact the derivative with respect to time itself is non-zero.
So +1 on the change, and OK for not adding specific tests, I agree it is difficult.
from hipparchus.
For the second regression, the problematic call to isZero seems to be on line 369 (on loopG in if statement). If one replaces is with getReal() == 0.0, the regression is gone
from hipparchus.
For the first regression, problem is on line 427 with afterRootG in if statement.
from hipparchus.
I'm struggling to create reproductible cases in Hipparchus that would serve as unit tests. I'm already struggling to find short ones in Orekit. @maisonobe you know FieldDetectorBasedEventState better than me, do you event understand exactly why these two lines are problematic when there is a time detection with a non-zero gradient in the independent variable?
I'm almost tempted to make the two changes without any tests checking that the regression doesn't occur again in the future. It's not good practise but FieldDetectorBasedEventState is not a reader-friendly class.
from hipparchus.
Solved via commit
from hipparchus.
Related Issues (20)
- Add constrained optimization HOT 12
- costant parameter error in class ADMMQPModifiedRuizEquilibrium HOT 1
- Add option for Butcher-based Field integrators to use doubles as coefficients
- Improvable performance in Gradient HOT 3
- Rotation.getAngles(ZYX, VECTOR_OPERATOR) inconsistent in 'Gimbal Lock' HOT 3
- Define reasonable iteration limit for `LaguerreSolver#solveAllComplex()`method
- Infinite loop with SQPOptimizerGM HOT 1
- Cannot invoke "Object.equals(Object)" because the return value of "org.hipparchus.geometry.partitioning.BSPTree.getAttribute()" is null HOT 2
- `EmpiricalDistribution#density()` shouldn't return `NaN` if kernel density is `0.0`
- Introduce Mockito as test dependency HOT 4
- Make JacobiKey public in PolynomialsUtils HOT 1
- CI/CD failure HOT 2
- Allow variable arguments to build PolynomialFunction
- Add inverse transform method to UnscentedTransformProvider
- Change visibility of Adams(Field)Integrator to protected
- Add Field version of GraggBulrischStoer integrator
- Add Gauss-Markov generator
- Change signature of currentInterval in (Field)AdapatableInterval
- Avoid exception "org.hipparchus.exception.MathIllegalArgumentException: matrix is singular" for complex implementations HOT 2
- Remove link to yandex
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hipparchus.