hikone / liquidlib Goto Github PK

It was extremely unfortunate to see this mod be taken down after the Tile update in tmod that turned Tile.cs into a struct. I've been working on porting this mod to the latest versions of tmod starting with tmod 1.4.3 and then to 1.4.4.

The reason why I'm updating this mod is simply due to ModLiquid taking years to develop and the lack of communication and the the on and off state the other developers are the main contributors of why its taking so long. (along with little use for ModLiquid compared to some features)
The reason why this will be ported to 1.4.3 first is due to how much Liquids changed in Terraria in the 1.4.4 update due to shimmer. Although not a lot there will still need to have major changes made such as liquid to liquid collision being merged into 1 method instead of the multiple it is in 1.4.3.

Here are some proposed changes that the mod will need
Removal of Liquid Bucket - Buckets should be implemented by the mods not the loader
Changes to how ModLiquid is registered to be similar to WaterStyle or ModTile
Add manipulation of light given by modded liquids
Add Map color
Add Pre/PostDraw
(more will be added here if things come to light)

I'll make a fork and PR eventually once my build is strong enough. Ill try and get all IL edits fixed tomorrow. Once a pr is made I'll link it here: {scrapped for now}
Fork link: https://github.com/Lion8cake/LiquidLib

Hello I have been testing around with this for a while and it feels really well done. I found one bug and have many suggestions for the mod.
The bug I found was that the modded bucket can't be researched in journey mode.
I have a few suggestions for the mod as well.

1. Moddded liquid sensor
   it would be really cool to also make a modded liquid sensor with your own modded liquid
2. Custom bubbles
   I like how it uses water bubbles as of now but the modded liquid I would like to make has custom bubbles similar to lava
3. Have the liquid apply a custom debuff
   I haven't really messed around with modded liquids and debuff/buffs yet but I would assume that this wouldn't be possible yet

A really awesome job at this mod and I will defiantly be using it the future to create my own liquids, keep up the good work.
(Im am completely understandable if some of the suggestions can't be done)
-Lion8cake