Make getChildren(), getFirstChild() and getLastChild() public about xhp-lib

[Swahvay]

So, this was originally done because we had this ideological vision of what XHP should be. Basically, each XHP component should be self-contained and no one outside that component should have visibility into what it's doing. If I were being strict I would still say this is the right way to go, and that to build things like you have above, you should put them in your XHP element so that you can just do:

$x = $this->my_xhp_code->getElementById("menu-header");
$x->prependChild(<br />);

But in reality it's a little shallow-minded to assume everyone wants these things to live in their core XHP hierarchy. Facebook made these functions public internally to support a XHP component explorer that references children. I'll make these public.

[Swahvay]

7181bd9

[thewavelength]

Thanks a ton! Please remember to do the same in core.php lines 23-25.

[Swahvay]

Oops, thanks. df6b276