Coder Social home page Coder Social logo

Comments (9)

jwatzman avatar jwatzman commented on June 14, 2024

A prerequisite to this would likely be changes to the HHVM cmake configuration so that we don't need the huge list of HHVM-only dependencies.

from homebrew-hhvm.

Orvid avatar Orvid commented on June 14, 2024

The hack section of the cmake build searches for its dependencies separately from HHVM.

from homebrew-hhvm.

jwatzman avatar jwatzman commented on June 14, 2024

Yes, but there is no mechanism to configure one without the other AFAIK, it's all tangled together. Or does CMake have some magic?

from homebrew-hhvm.

Orvid avatar Orvid commented on June 14, 2024

Adding SET(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/../../CMake" ${CMAKE_MODULE_PATH}) before the find_package calls in hphp/hack/CMakeLists.txt and then just calling cmake . from hphp/hack/ should work just fine.

from homebrew-hhvm.

Orvid avatar Orvid commented on June 14, 2024

Ideally it would be better to move the IF(HPHP_HOME) check out of the loop and use that as the base path for finding /CMake, but it's not required.

from homebrew-hhvm.

jwatzman avatar jwatzman commented on June 14, 2024

Ah, cool.

@raeesiqbal this isn't something I'm likely to have time to work on myself, but I'd be happy to review a PR to do it. (You'll need to update the CMake scripts in HHVM itself as above, then submit a change to the brew formula to take advantage of it.)

from homebrew-hhvm.

RaeesBhatti avatar RaeesBhatti commented on June 14, 2024

I'm not familiar with Ruby and HomeBrew formulas, so, I tried a lot of things but could not make cmake inside the hphp/hack directory work.
We can't just cmake HHVM first and then Hack because that will require a lot of packages to be present that Hack doesn't need. Here are my finding:

  • Hack requires lz4,libelf,ocaml to work, so, we can create a HomeBrew option with-hack-only and do a if not build.with? "hack-only" check on things which are not required by Hack.
  • We can actually build Hack utilities on Mac using configure, cmake . and make in hphp/hack directory when you have the dependecies installed.

from homebrew-hhvm.

fredemmott avatar fredemmott commented on June 14, 2024

That referenced commit means this is now supported by hhvm itself, just not by brew. Would also like this so that when the hhvm build is broken by folly/clang/apple can hopefully keep using nuclide with local hh_client

from homebrew-hhvm.

fredemmott avatar fredemmott commented on June 14, 2024

For now, I'm wontfixing this, as we should have bottles up very shortly (#5)

from homebrew-hhvm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.