glfw: potential memory leak reported by valgrind about mach

[slimsag]

Thank you for filing this, will investigate

[silversquirl]

@xor256 Assuming you're talking about mach-glfw, are you seeing any leaks unique to mach's wrapper? GLFW itself leaks memory on my system, so if that's what you're seeing, it should really be reported to upstream

[alichraghi]

does mach-glfw only uses c_allocator or other zig's allocators are used too? because as far as i know valgrind does't detect zig memory leaks

[slimsag]

@alichraghi we use only c_allocator internally, but the tests use other Zig allocators.

This issue was opened quite a while ago, possibly fixed. We just need someone with Linux to run with Valgrind to confirm

[alichraghi]

i ran the very simple code example in glfw documention in C and Zig (using mach). both almost have same valgrind output. i think it's because the window close duration difference. i also found some comments on the internet, they say detected leaks are caused by X11 or GPU Driver not GLFW
Zig:

definitely lost: 0 bytes in 0 blocks
indirectly lost: 0 bytes in 0 blocks
possibly lost: 178,039 bytes in 1,476 blocks
still reachable: 1,450,310 bytes in 1,993 blocks
suppressed: 1,700 bytes in 1 blocks

C:

definitely lost: 0 bytes in 0 blocks
indirectly lost: 0 bytes in 0 blocks
possibly lost: 178,311 bytes in 1,478 blocks
still reachable: 23,562,177 bytes in 4,380 blocks
suppressed: 1,700 bytes in 1 blocks

[slimsag]

Great, thanks for checking @alichraghi ! I'll close this, if anyone finds anything else here feel free to create a new issue!