Coder Social home page Coder Social logo

Comments (9)

TimTaylor avatar TimTaylor commented on June 16, 2024 2

To clarify - the "wish" is for when there is an explicit i. I know there are alternatives but I'd still like the default behaviour to be consistent and always return an object of the same type (data frame) irrespective of the length of j. Not, for example

rows <- 1:3
class(mtcars[rows, 1L])
#> [1] "numeric"
class(mtcars[rows, 1:2])
#> [1] "data.frame"

from wishlist-for-r.

gaborcsardi avatar gaborcsardi commented on June 16, 2024 1

@chainsawriot Then people's packages start behaving differently for each user and/or script. The option already didn't work for stringsAsFactors, it is not going to work for this, either.

from wishlist-for-r.

karoliskoncevicius avatar karoliskoncevicius commented on June 16, 2024

I noticed you only mentioned [.data.frame. Since data.frames are a hybrid between lists and matrices we can just use the list substitution [i], instead of the matrix way [,i]. So:

iris[1]
iris["Species"]
iris[c(1,2,3)]

All preserve data.frame without the need for drop=FALSE.

from wishlist-for-r.

ltuijnder avatar ltuijnder commented on June 16, 2024

As a package developer, I often have dynamic input in the j-slot that is user controlled. Forgetting the drop=FALSE can lead to nasty bugs as often the code afterward assumes the resulting object is still a data.frame.

from wishlist-for-r.

karoliskoncevicius avatar karoliskoncevicius commented on June 16, 2024

@ltuijnder as mentioned above: using df[j] instead of df[,j] should solve this problem for you.

from wishlist-for-r.

InductiveStep avatar InductiveStep commented on June 16, 2024

This recently confused me as I was writing code iterating over the rows of data frames and sometimes the data frame only had one column.

Here's an example of what went wrong:

> data.frame(x = 42)[1,]
[1] 42

I didn't want it to lose its data.frame-ness. tibbles have sensible defaults:

> tibble(x = 42)[1,]
# A tibble: 1 × 1
      x
  <dbl>
1    42

from wishlist-for-r.

JosiahParry avatar JosiahParry commented on June 16, 2024

This became a fairly divisive topic on Mastodon. This behavior is not intuitive or user friendly. https://fosstodon.org/@josi/111096750116664099

from wishlist-for-r.

karoliskoncevicius avatar karoliskoncevicius commented on June 16, 2024

This issue should be about matrices and arrays preserving dimensionality (and hence matrix/array objects) after [ selection. As it affects these objects first. And data.frame matrix-based selection would then follow too. Changing the behaviour only for data.frames would introduce an inconsistency between data.frame and matrix objects.

from wishlist-for-r.

chainsawriot avatar chainsawriot commented on June 16, 2024

As a possible interim solution is to make drop of current x[i, j, ... , drop = TRUE] to getOption("default.drop", TRUE), i.e. x[i, j, ... , drop = getOption("default.drop", TRUE)].

It can then be set per session (or per user, if one puts that in the initialization script): options(default.drop = FALSE).

from wishlist-for-r.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.