Coder Social home page Coder Social logo

Comments (3)

mgomes avatar mgomes commented on May 25, 2024

@luizcarvalho I checked out your closed PR.. it makes sense to me, actually. I'd hate to keep adding in more Facebook-specific code to Stealth as we've already done with payload.

The only downside to your existing approach seems to be that we pollute the payload namespace with built-in payloads. But what if maybe we just came up with a naming convention to account for that? For example, maybe all built-in payloads start with _, and so the read payload would be _read or something like that. This way too we can add support for all of the other webhooks Facebook supports (https://developers.facebook.com/docs/messenger-platform/webhook).

What do you think?

from stealth.

luizcarvalho avatar luizcarvalho commented on May 25, 2024

I think this may work, I'll try to use this convention to create a new PR =)

thanks @mgomes

from stealth.

mgomes avatar mgomes commented on May 25, 2024

Closing this once since it's been merged in stealth-facebook. 👍

from stealth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.