Comments (6)
Hi Kilian,
Thanks for your message.
Hmmm, I'm not sure this would be a good idea for the following reasons:
- Rather than having the auth tokens managed in a central location (either framework or project property file) it could lead to users adding the same room token multiple times in the UI (each time a notification is configured for a particular room which could be within the same job and/or across multiple jobs/projects).
- Also would mean the auth token(s) gets displayed in clear text in the UI (if it has been configured there rather than the property files) which could have some security implications
What was the reasoning behind wanting this as an instance level property?
Cheers,
Hayden
from rundeck-hipchat-plugin.
Hey Hayden,
The reasons in wanting the change are these:
- I have a lot of rooms; more that makes it practical to create a token for each and configure them in rundeck.
- The rooms can be short lived so keeping them all in framework.properties would be a lot of on going overhead.
I was thinking the tokens being displayed in clear text wasn't as big of an since they are displayed in the same way in hipchat.
Agreed it is more configuration and could lead other users to configure unnecessary details in the job definition. But perhaps could be mitigated with further description?
Kilian.
from rundeck-hipchat-plugin.
Hey Kilian,
Mmmk, sounds like you have a valid case there. Having a read through the latest plugin doco suggests I may be able to hide the auth token in the UI by flagging it as a password in the rendering options for the field. I'll take a closer look at this tomorrow and will let you know once done.
Cheers,
Hayden
from rundeck-hipchat-plugin.
Hi Kilian,
Ok so I've added another (instance scope only) property that can be used to override the auth token used in the framework/project property (I ran into some issues trying to use the same property). So you should be able to use this to configure the auth token in the GUI. This has been released and should be synced out to maven central soon. Please let me know if this solves your problem.
Cheers,
Hayden
from rundeck-hipchat-plugin.
Happy days Hayden,
I tested it out and v1.7.0 is looking good.
Thanks,
Kilian.
from rundeck-hipchat-plugin.
That's great - thanks for the confirmation. I'll close this issue off then. Please let me know if you have any further issues/feedback.
Cheers,
Hayden
from rundeck-hipchat-plugin.
Related Issues (13)
- Seeing weird error in logs HOT 9
- Room notification HOT 1
- Any Error in the Notification will abort the job HOT 1
- This plugin requiere IPv4. HOT 8
- Hipchat plugin does not work HOT 2
- Unknown or unsupported HipChat API version: [v2 ] HOT 2
- Expression executionData.context is undefined HOT 6
- HipChat Server HOT 4
- Add support for HipChat REST API version 2 HOT 2
- Add proxy support HOT 4
- Hipchat SSL API V2 broken HOT 1
- Rundeck fails to connect to hipchat HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rundeck-hipchat-plugin.