Cannot read property 'toString' of undefined when building schema about pothos

[mmahalwy]

Woohoo! Fixed! Thanks a bunch for this!

[mmahalwy]

Happening because of circular dependencies.

[hayes]

Interesting. This path should only get called when creating a (different) error. It is trying to create a name for a ref which hasn't been implemented, but the ref is undefined. My guess would be some sort of circular import causing undefined to be passed as a ref because the file it was imported from hasn't run. Can't tell for sure what's causing it from that stack trace.

[hayes]

Error message in this case should be better, and I should probably just have a runtime check to disallow undefined as ref

[mmahalwy]

Once I moved the objects into their own files, this error went away. I do think it's circular import is the problem.

[hayes]

How were the problematic refs being used? Anything inside a fields function should alread get deferred to allow circular references.

[hayes]

Actually, I think I see how this could still happen. I'm on a road trip, but will work on a fix soon

[mmahalwy]

No worries. I was able to replicate it with recursive inputs:

export const ApplicationFieldConfigInput = builder
  .inputRef<ApplicationFieldConfig>('ApplicationFieldConfigInput')
  .implement({
    fields: (t) => ({
      name: t.string({ required: true }),
      label: t.string({ required: true }),
      type: t.field({ required: true, type: ApplicationFieldConfigTypeEnum }),
      fieldPath: t.string({}),
      fieldHandlers: t.field({
        required: true,
        type: [ApplicationFieldConfigFieldHandlerEnum],
      }),
      options: t.stringList({ required: true }),
      modelPath: t.string({}),
      docspringPath: t.string({}),
      visibleIf: t.string({}),
      requiredIf: t.string({}),
      validations: t.string({}),
      defaultRequired: t.boolean({ defaultValue: false }),
      defaultShow: t.boolean({ defaultValue: true }),
      defaultLocked: t.boolean({ defaultValue: false }),
      children: t.field({ required: true, type: [ApplicationFieldConfigInput] }),
    }),
  });

Also recursive on object:

export const ApplicationFieldConfigObject: ObjectRef<ApplicationFieldConfig> = builder
  .objectRef<ApplicationFieldConfig>('ApplicationFieldConfig')
  .implement({
    fields: (t) => ({
      name: t.exposeString('name', {}),
      label: t.exposeString('label', {}),
      type: t.expose('type', { type: ApplicationFieldConfigTypeEnum }),
      fieldPath: t.exposeString('fieldPath', { nullable: true }),
      fieldHandlers: t.expose('fieldHandlers', {
        type: [ApplicationFieldConfigFieldHandlerEnum],
      }),
      options: t.exposeStringList('options', {}),
      modelPath: t.exposeString('modelPath', { nullable: true }),
      docspringPath: t.exposeString('docspringPath', { nullable: true }),
      visibleIf: t.exposeString('visibleIf', { nullable: true }),
      requiredIf: t.exposeString('requiredIf', { nullable: true }),
      validations: t.exposeString('validations', { nullable: true }),
      defaultRequired: t.exposeBoolean('defaultRequired', { nullable: true }),
      defaultShow: t.exposeBoolean('defaultShow', { nullable: true }),
      defaultLocked: t.exposeBoolean('defaultLocked', { nullable: true }),
      // children: t.expose('children', { type: [ApplicationFieldConfigObject] }),
    }),
  });

[hayes]

Pushed a new version that should help with these. There was a bit of a regression here, but added a test specifically for recursive imports.

[hayes]

I think my recursive inputs split the implement step into a separate statement which is why they were not failing