Coder Social home page Coder Social logo

Comments (4)

harrelfe avatar harrelfe commented on August 17, 2024

Sorry to not have gotten to this sooner. The confidence intervals appear to be correct but the hazard ratios are exp(-beta). I'll take a look at the code to try to debug. If you have time to look at it earlier than I get to it that would be great (code for orm and summary.rms).

from rms.

yhpua avatar yhpua commented on August 17, 2024

Dear Prof. Harrell,

Thank you so much for your reply! I have noticed that the loglog link function in orm.fit.s is given by -log(-log(x )) and not log(-log(x )) as stated in your excellent Regression Modeling Strategies book (Table 15.1, page 362). If the loglog link function is -log(-log(x )), exp(beta) will be given by logP1/logP2 while exp(-beta) will be given by logP2/logP1. If so, does exp(-beta) give the correct Hazard Ratio?

from rms.

harrelfe avatar harrelfe commented on August 17, 2024

The logic in summary.orm was unnecessarily complex. Thanks for pointing this out. For the PH model (log-log link) I was negating the linear predictor before anti-logging, but was leaving the confidence limits in their original form. So the confidence limits were correct all along, and the point estimate was wrong. I'll have that logic removed for the next submission to CRAN. Changes will be committed to Github momentarily. Let me know if this change does not makes sense.

from rms.

yhpua avatar yhpua commented on August 17, 2024

Thank you for making those changes.

from rms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.