Comments (5)
I don't currently recall the inner workings of the code off the top of my head, sorry. I'm preoccupied with a project deliverable at the moment so I can't get into it right now either, so you'll have to dig in 🍚 :)
from vscode-duktape-debug.
Yeah I've already looked it into a bit. It doesn't appear to be handling it. From what I can work out getBreakpointsForFile
is returning an array of breakpoints with dukIdx
in ascending order. They're getting added to the remBPs
array in ascending order as well.
If kept this way doRemoveBreakpoints
will have to shift all the dukIdx
values down every time it calls requestRemoveBreakpoint
to keep them in-line with duktape (If you remove index 5, then the breakpoint you have at index 8 would now be at 7, but duktape is being asked to remove at index 8).
I think a better way would be to have the remBPs
array sorted such that the dukIdx
are in descending order, because then you don't have to care that all the indices above the index you just removed got shifted.
from vscode-duktape-debug.
If I recall, the packed index were accounted for. I can't quite recall specifics, so I'll have a look when I get the chance to refactor.
from vscode-duktape-debug.
It is accounted for in removeAllTargetBreakpoints
but if it's accounted for in setBreakPointsRequest
then I've misread some logic somewhere.
from vscode-duktape-debug.
Thanks, I'll also have a look when I get the chance to dive back in 👍
from vscode-duktape-debug.
Related Issues (20)
- Another breakpoint not hit problem HOT 1
- evalcall >255 params
- How to debug debug-protocol issues? HOT 7
- Debugger not working with duktape 2.1.1 HOT 2
- Debugger symbol output is messed up HOT 12
- VSCode is no longer supporting specifiying a commandId in the "initialConfigurations" contribution HOT 2
- Virtual properties are not getting listed
- Option for hiding hidden symbols
- New release required HOT 3
- Source unknown in callstack HOT 2
- Errors when running vscode with duktape HOT 3
- need to put debugger; in javascript to catch the breakpoints HOT 2
- [Q] Trying to increase read buffer size HOT 3
- Looking for maintainers? HOT 2
- Configuring the debugger with multiple source roots HOT 13
- Add runtimePrefix option HOT 1
- Breakpoints and source files HOT 15
- TypeError: e.resume is not a function HOT 2
- Exception on print() only in --debugger mode
- Prefixing "file:///" to Windows absolute paths causes "Unknown source file" HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-duktape-debug.