relative path not supported about gulp-file-include

[haoxins]

base on path of gulpfile

[wiz-Cll]

it SHOULD base on the path of file who use @@include

[haoxins]

add a option dir.

[haoxins]

@wiz-Cll please try v0.3.0 and give a feedback.
If everything is ok, close this issue.>_<

[r4fx]

Can you explain how to use it? I still have problem with partials

[haoxins]

is this example helpful?

[r4fx]

not exactly, I am looking for solutions for my case klei/gulp-inject#33

[tsi]

Me too.
I'm trying to do multi-level nested includes. e.g. include a file that includes other files.
If possible, referencing the path of file who use @@include will be helpful, or alternatively referencing the location of the gulp.js file would be fine.
Using @root was promising but didn't help since it was referencing my node_modules/gulp-file-include which lays outside of my project (is that normal?)
And giving an absolute path works fine for me but might break if I pass it to a developer with different path to the project.

[haoxins]

gulp-file-include which lays outside of my project

haha, maybe is not normal, but I'll consider this.

And giving an absolute path works fine for me but might break if I pass it to a developer with different path to the project.

yes, absolute path is not good.

about @file, yes, seems some bugs, I'll fix it

[haoxins]

actually, @file is relate to the file pass to gulp stream.

[haoxins]

@tsi , I think @file all relate to the file pass to gulp stream is simple.

I'll fix the readme

[haoxins]

@tsi
please see example

[tsi]

Yes, your example describes (but not solving) my problem very well:
All include paths are relative to index.html, even those called from the inner partials (e.g. a1.html).
Now, in my forked example I have a second page at a sub directory - /pages/somepage.html
I am able to call a1.html from page.html since I changed the path from a/a1/a1.html to ../a/a1/a1.html but the process will fail since a1.html includes a2.html using a path relative to index.html.
The best solution I can think of is allowing paths to be relative to gulp.js which is constant and can be referenced from anywhere safely.
Thanks!

[tsi]

@coderhaoxin did you see this? I realize this issue is closed, should I open a new one?

[janpaepke]

I think I know what the problem is.
The basepath is only set for the first file that is included.
So all further inclusions are relative to it, even if it in turn includes new files.

Imagine this structure:

|--file1.html
|--folder1
   |--file2.html
   |--folder2
      |--file3.html

Scenario: File1 includes File2 and File2 includes File3.

Now when I chose @file as the basepath what I expect would be this:
File1: @@include('folder1/file2.html')
File2: @@include('folder2/file3.html')

However this does not work because the plugin is looking for folder 2 in the same level as file1, because this was the first one to be included and thus set the basepath.
The only way it does work is like this:
File1: @@include('folder1/file2.html')
File2: @@include('folder1/folder2/file3.html')

Because files, especially when using relative paths, should be agnostic to which file includes them I think this is clearly a bug.

I will have a look at the source and see if I can figure out a quick fix.

[haoxins]

@janpaepke yes, you're right.

But that will broken.

[haoxins]

@janpaepke pr welcome. Just need a big version.

[janpaepke]

I made some changes and it works as expected for my usecase now.
It does fail one test though and I don't have more time to look into it.
But I guess it's a starting point...

[janpaepke]

glad I could help :)

[haoxins]

👍 thanks