Value shows incorrectly when minValue applied about steelseries-canvas

[mcrossley]

Thanks for the bug report.

I cannot reproduce on the radial gauge, but can see the problem on the
radialbargraph, I'll check out all the relevant gauges... I also need to
fix the default threshold value to make it mid-scale.

Mark

On 3 May 2013 20:02, Scott Elcomb [email protected] wrote:

This screenshot shows an example of the problem I'm running into: [image:
issue screenshot]https://a248.e.akamai.net/camo.github.com/46f55dad6e6786eeb86f545815344772e4a8e016/687474703a2f2f70726f6a656374732e7073656d61342e636f6d2f737465656c7365726965732d63616e7661732f537465656c5365726965732d4d696e56616c75652d49737375652e706e67

Source is a modified version of demoRadial.html that shows two TYPE4
radial gauges side-by-side. They're set to show the same value, but with
differing minValue's (the first being set to 0, the second to 10).

Issue appears to affect TYPE4 linear bargraphs as well.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7
.

[mcrossley]

Scott

v0.14.1 just uploaded should fix these issues.

Cheers
Mark

On 5 May 2013 18:04, Mark Crossley [email protected] wrote:

Thanks for the bug report.

I cannot reproduce on the radial gauge, but can see the problem on the
radialbargraph, I'll check out all the relevant gauges... I also need to
fix the default threshold value to make it mid-scale.

Mark

On 3 May 2013 20:02, Scott Elcomb [email protected] wrote:

This screenshot shows an example of the problem I'm running into: [image:
issue screenshot]https://a248.e.akamai.net/camo.github.com/46f55dad6e6786eeb86f545815344772e4a8e016/687474703a2f2f70726f6a656374732e7073656d61342e636f6d2f737465656c7365726965732d63616e7661732f537465656c5365726965732d4d696e56616c75652d49737375652e706e67

Source is a modified version of demoRadial.html that shows two TYPE4
radial gauges side-by-side. They're set to show the same value, but with
differing minValue's (the first being set to 0, the second to 10).

Issue appears to affect TYPE4 linear bargraphs as well.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7
.

[psema4]

Thanks for looking into this Mark. I'm still seeing the issue with some of the Linear graphs. (I may have a fix for the radial gauges; I'll test a bit further and submit a pull request in a few hours)

To best demonstrate what I'm seeing, I've cloned a copy of the repo, modified the source examples, repackaged and put it up on my site.

The modified examples can be found in the Issue7 folder. Diffs are available in the same folder that show the modifications made to the demoRadial.html and demoLinear.html examples. These modifications simply add minValue & maxValue to each gauge and then ties them together so they display the same value simultaneously.

[psema4]

Looks like the radial and most of the linear graphs are indeed fixed. In the tests mentioned yesterday I'd used the minified version; the unminified version appears to fix everything except canvasLinear6 in demoLinear.html

[mcrossley]

Thanks Scott, I thought I had fixed it, but I was doubting what I had done!
I'll take a look at the remaining issue tomorrow...

On 14 May 2013 18:56, Scott Elcomb [email protected] wrote:

Looks like the radial and most of the linear graphs are indeed fixed. In
the tests mentioned yesterday I'd used the minified version; the unminified
version appears to fix everything except canvasLinear6 in demoLinear.html

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-17893356
.

[mcrossley]

Actually, it was a trivial change, so pushed up v0.14.2 just now - and
remembered to update the minimised version this time ;-)

On 14 May 2013 22:09, Mark Crossley [email protected] wrote:

Thanks Scott, I thought I had fixed it, but I was doubting what I had
done! I'll take a look at the remaining issue tomorrow...

On 14 May 2013 18:56, Scott Elcomb [email protected] wrote:

Looks like the radial and most of the linear graphs are indeed fixed. In
the tests mentioned yesterday I'd used the minified version; the unminified
version appears to fix everything except canvasLinear6 in demoLinear.html

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-17893356
.

[psema4]

Awesome, looks good here.

Thanks for your help - it's most appreciated!