Comments (11)
@jodosha I'd be glad to, and I've tried, before submitting this issue and again today...
@AlfonsoUceda Do you have any lead I could look into?
from router.
Hi @TiteiKo have you tried mount Admin::Application, at: '/:locale/admin'
without parenthesis? I am just writing without trying in the laptop because I'm not in front of it.
from router.
@AlfonsoUceda Yep, same problem in urls generation with and without parenthesis. Generated urls looks like /:locale/admin/users?locale=en
from router.
I'll try to take a look this weekend @TiteiKo
from router.
Hi @TiteiKo I was researching the problem and it seems, there is a bug that you can't use variables
in the container. So I have to see how I can fix it, sorry for the problem :(
from router.
Hi @AlfonsoUceda
Thanks for your time and the update! Glad I could uncover a bug, and no problem, Hanami's not supposed to be stable yet, and I'll still be able to work in the meantime, it's the last thing on my backlog for v1 ;)
from router.
@TiteiKo @AlfonsoUceda Hi, this isn't a bug, it's just not possible to do so at the moment.
Because @TiteiKo is interested in this change, I suggest her to implement it.
At this point in time, it's beneficial that Hanami shareholders can write enhancements or features for real world apps.
from router.
Hi @TiteiKo
You can start here, the prefix in the container ends in that variable, when I was tackling this, one of my ideas was creating a class to handle that, replace :variables
in that prefix with options passed to the path or url to generate.
from router.
@TiteiKo Is this something still interesting for you to implement?
from router.
@jodosha Not ATM, no. I've tried to do it, but without success. I'll use a rewrite rule on nginx to go from /:locale/admin
to /admin/:locale
After looking at the code, I think it would make a lot of changes for a very specific need that would probably not occur on a fresh new project.
from router.
@TiteiKo Thank you 😄
from router.
Related Issues (20)
- BodyParser's fallback "_" key in env["router.params"] unnecessary for typical x-www-form-urlencoded bodies? HOT 2
- http_router dependency generates `warning: URI.unescape is obsolete` HOT 3
- Standalone routing with method override HOT 2
- Warning: URI.unescape is obsolete HOT 2
- Nested variables/resources HOT 2
- Fake support for Ruby 3 HOT 2
- POST route recognised as GET HOT 2
- 405 response does not include Allow header
- Surprising prefix behavior HOT 2
- Unclear errors with differently named wildcard segments HOT 5
- URL fragments and routing HOT 2
- Exception when JSON body contains % HOT 7
- Failing edge cases for optional variables
- Path segments in base_url can get clobbered by UrlHelpers
- Per-slice middleware not being applied correctly? HOT 3
- Capture names affects finding nested routes HOT 2
- Catch-all has higher priority than mount HOT 2
- Routes with multiple variables not working in common nested route scenario HOT 2
- Inconsistent trailing slash behaviour HOT 1
- Middleware usage does not work as expected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from router.