Coder Social home page Coder Social logo

Comments (7)

hailwood avatar hailwood commented on July 24, 2024

Actually that is the way that the function works now!

You will receive an object for that param that looks something like

{
    label: 'label',
    value: 'value',
    element: [Dom Element] // represents the actual dom element for that tag
}

from jquery-tagit.

sfmskywalker avatar sfmskywalker commented on July 24, 2024

Awesome, I'll check it out! Thanks.

from jquery-tagit.

sfmskywalker avatar sfmskywalker commented on July 24, 2024

I just checked, but when I remove a tag, null is passed as the 3rd argument. Looking at the invoking code in the _popTag function, it makes sense:

this.options.tagsChanged(tag.value || tag.label, 'popped', null);

null is explicitly passed.
Any reason why the actual popped tag is not being passed in?

from jquery-tagit.

hailwood avatar hailwood commented on July 24, 2024

There we go, just updated it so it passes the tag through (a8bed19).

I guess I did it because in the tag object there is also the index of the tag, and the actual element, both of which make no sense once the tag has been removed, but I guess people can just ignore those.

from jquery-tagit.

sfmskywalker avatar sfmskywalker commented on July 24, 2024

Yeah that makes sense. The reason I need the tag object is to update other elements on the screen that are related to the tag being removed.

Thanks for the quick response.

from jquery-tagit.

hailwood avatar hailwood commented on July 24, 2024

All good, I try :) btw, out of curiosity, what version are you using? the ThemeRoller version or the non-ThemeRoller version?

from jquery-tagit.

sfmskywalker avatar sfmskywalker commented on July 24, 2024

Excellent :) Currently I'm using the non-ThemeRoller one, since the default style is perfect for my needs (I manually changed some colors and borders). It's also the first time I used this (rather awesome) plugin, it's being used for the next version of the Orchard Taxonomies module.

from jquery-tagit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.