First, I apologize as I cannot reproduce consistently the issue and cannot share the c

Hello, I've recently made some changes to the injection machinery recently whic

TypeError: can't access dead object in patchWindow.js about nscl HOT 5 OPEN

jamhubhub commented on August 15, 2024

TypeError: can't access dead object in patchWindow.js

from nscl.

Comments (5)

jamhubhub commented on August 15, 2024 1

I found a way to reproduce the issue consistently with a minimal code example. It looks like the issue comes either from the NSCL or from Firefox / Tor Browser? Steps to reproduce the issue:

Create a file first.html:

<html>
    <head>
        <meta charset="UTF-8">
    </head>
    <body>
        <button onclick="document.createElement('div').appendChild(document.createElement('div'));">
            Add something to the DOM
        </button>
        <br/>
        <a href="second.html">second.html</a>
    </body>
</html>

Create a file second.html:

<html>
    <head>
        <meta charset="UTF-8">
    </head>
    <body>
    </body>
</html>

Open Tor Browser 11.0.14, based on Mozilla Firefox 91.10.0esr, NoScript version 11.4.6, and set the Tor Browser security level to "Safer". Open the browser console to monitor the issue.
Open first.html as a local file. Click the button, no issue. Click the link. Go back to the previous page using the browser "left arrow" button. Click the button again, a DOMException is thrown. The browser console indicates the exception comes from patchWindow.js:299. Using the browser debugger seems to indicate the initial exception comes from patchWindow.js:285.

The issue doesn't come up when using Tor Browser security level "Normal".

from nscl.

mriehm commented on August 15, 2024 1

I have been seeing this problem in Firefox on Android.
On initial load of a Wikipedia page, tapping the article section headers successfully expands/collapses that section of the article. However, if I tap a link within the article to go to a different article, and then I use the Back button to go back to the original article, tapping the article section headers will no longer expand/collapse the section. When I attached Firefox debugging, I see that tapping the section header triggers the same 'TypeError: can't access dead object' error for the 'win' object in the line 'for (let j = 0; j in win; j++)' reported in this issue.

I am on version 11.4.25 of the extension.

from nscl.

hackademix commented on August 15, 2024

Hi, thank you for the report and the reduced test case.
At first glance, it seems a lifecycle mismatch between the page retrieved from BF Cache and the extension content script.
Not your code's fault, anyway.
Investigating...

from nscl.

hackademix commented on August 15, 2024

Hello, I've recently made some changes to the script injection machinery recently which are likely to affect this issue.
Can you still reproduce on NoScript 11.4.19rc3?
Thanks!

from nscl.

hackademix commented on August 15, 2024

On initial load of a Wikipedia page

Thank you very much for this test case. I could reproduce indeed, and I'm investigating it.

from nscl.

TypeError: can't access dead object in patchWindow.js about nscl HOT 5 OPEN

Comments (5)

Related Issues (5)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent