Coder Social home page Coder Social logo

Comments (9)

H2Owater425 avatar H2Owater425 commented on June 3, 2024 1

I found what's wrong with them, Hitomi used to use the number of frontends to get the first letter of the subdomain, but recently they changed that into a meaningless number.
I tested the new code and worked well, as I said in #11, a new feature premeditated in #8 will be added with the bug fix in future release.

image

from node-hitomi.

H2Owater425 avatar H2Owater425 commented on June 3, 2024 1

I guess Hitomi recently changed its method to get the subdomain of the image again. I'll examine Hitomi's code as soon as I get arrived at home.

from node-hitomi.

H2Owater425 avatar H2Owater425 commented on June 3, 2024 1

화면 캡처 2021-09-12 183940
I released a new release with few bug fixes including this one, please check it out!
Release [email protected] · H2Owater425/node-hitomi

from node-hitomi.

H2Owater425 avatar H2Owater425 commented on June 3, 2024

Okay, I just checked that hitomi rewrote it's subdomain-creating logic.
I think I have to examine again to write the code, since it is too late in my time zone, I'll do it later, sorry...

from node-hitomi.

dnm13 avatar dnm13 commented on June 3, 2024

Okay, I just checked that hitomi rewrote it's subdomain-creating logic.
I think I have to examine again to write the code, since it is too late in my time zone, I'll do it later, sorry...

don't worry about rushing it
and you've done nothing to apologize for

from node-hitomi.

H2Owater425 avatar H2Owater425 commented on June 3, 2024

Even there's been a lot of big ups and downs, the new version of the package has finally been released!
Thanks for noticing me about the errors to let me fix them, here's the changelog (and what I have done wrong 😥) about this update Release [email protected] · H2Owater425/node-hitomi!

from node-hitomi.

dnm13 avatar dnm13 commented on June 3, 2024

image
great job!
it works properly now, thanks for fixing it :)

from node-hitomi.

dnm13 avatar dnm13 commented on June 3, 2024

it occasionally would return invalid / wrong sub domain
image

from browser inspect:
image

you can check it from code 1989850 page 47 (the picture said 46 but it's because index start from 0)
going to reopen the issue with this comment. hopefully you can fix it

from node-hitomi.

dnm13 avatar dnm13 commented on June 3, 2024

image
works like charm
thanks for the quick fix! much appreciated :)

from node-hitomi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.