Comments (6)
With so many issues caused by wrapping context storage in http.Request.Body , I think we urgently need a solution for context storing.
Yeah, that was a design mistake, but I have plans to migrate to net/context
in v2
.
The good thing is that you're not restricted to use the built-in context provided in gentleman
, you can now rely on net/context
if you want.
from gentleman.
@h2non Yes! I am using gentleman@v2.
For now, it doesn't cause any issue in my use scene.
from gentleman.
The most important reason I using this project is the context. (The middleware and plugin system are also great features)
It will be close to perfect for me if this issue be solved.
Thanks for your work. It helped me save a lot of time, although I spent some time to debug. LOL
from gentleman.
I have just pushed v2
preview release, which relies on stdlib context
and gets the rid of all the previous issues with the built-in context.
Code lives in v2
branch:
https://github.com/h2non/gentleman/tree/v2
There's also an outgoing PR that would be eventually merged once the new release is more mature and I had the change to port third-party plugins/packages too: #26
You should be able to use it via:
go get gopkg.in/h2non/gentleman.v2
Let me know how it works.
from gentleman.
Ping! Did you test this in gentleman@v2
? If yes, please let me know how it works!
from gentleman.
gentleman@v2
is finally there: https://github.com/h2non/gentleman
from gentleman.
Related Issues (20)
- Add Files() usage to Readme. HOT 1
- client.URL or client.BaseURL undefined behavior
- Please add method to remove headers from a request HOT 1
- Add a String() method to Request HOT 2
- Tracking what is done by a stack of plugins is hard
- Support standard rfc6570 URL Template syntax and replacement
- Issue with escaping parameters
- Issue pulling as a Go Module HOT 7
- Enhance redirect plugin to allow for trusted hosts HOT 2
- How to disable redirect
- http/1.1 and http/2 HOT 1
- The checksum on sum.golang.org is incorrect
- Default gentleman use doesn't seem to participate in TLS session resumption
- Making HTTP requests via CloudFlare
- gentleman/proxy error in example and code
- While using mutlipart form-data I am not able to set fieldName diff from fileName HOT 1
- GetBody() the Method in Golang is not define in gentleman.
- The expression data pass is empty
- Is Gentleman client thread safe? HOT 1
- the example for timeout is ambiguity
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gentleman.