Dark Skin about unitymarkdownviewer

[gwaredd]

You can change the skin by editing Editor/Skin ...

[MostHated]

It would be super helpful if there was a dark skin included that could be selected, or detect the current Editor skin and apply it.

[gwaredd]

It should be relatively easy, do you have a theme already?

[MostHated]

I do not. I tried to see if I could edit the one that was included, but for some reason, as soon as I click on the skin file my editor seems to come to nearly a complete halt and trying to click on anything within the skin file takes nearly 30 seconds to get a result. As soon as I click off/away from the skin file so that it is deselected, everything is fine again. Trying to simply locate and edit wherever I would need to, to simply change the background color became quite frustrating rather quickly.

It was a rather small project with no much going on to begin with, and I know it is not my pc as I have a R9 3950x with 64gb ram. I have not really dealt with skin files much in the past, though, so I am not sure if this is a common occurrence?

I don't know if they are setup specifically per application/useage to where I could try and locate one from some other project and use it, but considering now that the Unity editor comes with a dark theme enabled by default, (the super bright white backgound really hits you in the eyes if you are not expecting it, lol) it would be great if one were included and enabled by default.

[gwaredd]

I'll have to "roadmap" this feature until I have a bit more time ...

[MostHated]

Hey there,
I just saw the update with the dark skin, looks so much nicer, so thanks for that. One thing I noticed as soon as I opened it up though and clicked on the README.md was this:

The text seems to be overlapping the above header? I will try it out in a fresh project though to make sure it's not something on my end.

---

Edit

Looks like it might be on my end, I tried it on a fresh 2020.1 project, the prior was 2019.4.x, and it seems like the overlap is good in this one, but the actual size of the view area is restricted.

[gwaredd]

Checked in an update, see if that helps

[MostHated]

Hmmm.. I did a pull and saw the changes, deleted it from both the 2019.4 and 2020.1 projects and copied it in fresh, but had the same result in both. Just to be sure, I deleted it entirely, recloned it, tried again, still the same for some reason, where the view is only about 1/3 of the overall inspector panel. It looks great otherwise, at least. 👍 lol

[Theadd]

#4 (comment)

the view is only about 1/3 of the overall inspector panel.

UnityMarkdownViewer/Editor/Scripts/MarkdownViewer.cs

Lines 85 to 87 in 295c6b8

	// fix for Screen.height
	var offset = 450.0f;
	var scale = 2.0f;

It's more of a patch than a fix but changing the lines above to the following ones provides a better view

            // fix for Screen.height
            var offset = 0.0f;
            var scale  = 1.6f;

[MostHated]

Ok, nice. I was able to get it looking solid with the following by changing offset to be an additional amount instead of subtracting:

// fix for Screen.height
var offset = 300.0f;
var scale  = 1.6f;

// calculate working space
if( Event.current.type == EventType.Layout )
{
    mHeight = ( Screen.height + offset ) / scale;
}

Not sure if that might end up causing other issues elsewhere, but at least with just checking around a little, it seems to be solid like that.

[gwaredd]

I see the issue here. As far as I can tell, the MarkdownViewer.Draw() code is a pile of nonsense! ;)