Comments (4)
Hi Volter,
The whole point of us moving to TinyXML instead of the old Expat based
XML code was to avoid having to have yet another external dependency
to build against.
If you could send in a patch that could optionally allow us to build
against the embedded TinyXML or an external one if it was found I
think that would be more appropriate than removing the embedded
TinyXML completely.
Thanks,
Jason
On Sun, Sep 11, 2011 at 8:51 AM, volter
[email protected]
wrote:
Please don't bundle TinyXML.
I threw together a Cmake script and patched Cmakelists.txt:
http://www.geofrogger.net/review/osgEarth-2.0-FindTinyXML.cmake
http://www.geofrogger.net/review/osgEarth-2.0-tinyxml.patchNote that the patch was written for version 2.0.0.
Reply to this email directly or view it on GitHub:
#29
from osgearth.
I hope this works. I can't really test it because osgearth trunk doesn't build for me -- probably because of my OpenSceneGraph version.
The patch modifies CMakeLists.txt and src/osgearth/CMakeLists.txt and adds a find script in CMakeModules.
-D WITH_EXTERNAL_TINYXML causes the find script to run.
The find scripts has TINYXML_INCLUDE_DIR and TINYXML_LIBRARY. If both have values, TINYXML_FOUND is true.
If TINYXML_FOUND is true in src/osgearth/CMakeLists.txt, the bundled TinyXML files are not compiled. Therefore TINYXML_INCLUDE_DIR and TINYXML_LIBRARY are turned to use.
http://www.geofrogger.net/review/osgearth-external-tinyxml.patch
from osgearth.
Hi Volter,
I've pushed this change, thanks!
Jason
On Wed, Oct 12, 2011 at 6:20 PM, volter
[email protected]
wrote:
I hope this works. I can't really test it because osgearth trunk doesn't build for me -- probably because of my OpenSceneGraph version.
The patch modifies CMakeLists.txt and src/osgearth/CMakeLists.txt and adds a find script in CMakeModules.
-D WITH_EXTERNAL_TINYXML causes the find script to run.
The find scripts has TINYXML_INCLUDE_DIR and TINYXML_LIBRARY. If both have values, TINYXML_FOUND is true.
If TINYXML_FOUND is true in src/osgearth/CMakeLists.txt, the bundled TinyXML files are not compiled. Therefore TINYXML_INCLUDE_DIR and TINYXML_LIBRARY are turned to use.
http://www.geofrogger.net/review/osgearth-external-tinyxml.patch
Reply to this email directly or view it on GitHub:
#29 (comment)
from osgearth.
This is in the trunk now.
from osgearth.
Related Issues (20)
- osgearth_viewer get the white globe when load a earth file HOT 2
- Cannot load 3dtiles by CesiumNative3DTiles layer HOT 5
- Moon texture is bad
- Registry::programRepo is shared across all contexts HOT 1
- BUG - OSG version is not retrieved HOT 3
- How to prevent the map from being dragged outside the view? HOT 2
- ShaderGenerator don't work model loaded black without texturing HOT 5
- Draping: using depth-offset with draping causes artifacts HOT 3
- Version 3.5 not available through vcpkg HOT 1
- Dependencies Not Propagates to Consuming Projects HOT 4
- TerrainConstraint - does not work properly with a projected map
- detected OpenGL error invalid operation at after renderBin::draw(..) HOT 2
- osgearth_conv command that worked in 3.5 failing with segfault on tip HOT 3
- Build legacy controls api - wrong option
- Decluttering - crash in Voronoi code
- Building kdtrees at runtime is too slow
- Pick objects from OGRFeatureSource HOT 2
- Cache-only mode: various layers don't support it correctly
- Trouble with osgEarthCesium HOT 5
- A question about node or feature's edit HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osgearth.