Coder Social home page Coder Social logo

Comments (10)

guybedford avatar guybedford commented on August 12, 2024

The only thing I can see that might be causing a conflict is that grunt rewrites the node/print module which is also used by require-css.

Perhaps try commenting out these lines in css-builder.js here (comment out lines 3 - 8) - https://github.com/guybedford/require-css/blob/master/css-builder.js#L3.

I will test it out myself soon anyway though, but that is just if you need it more urgently.

from require-css.

andreu86 avatar andreu86 commented on August 12, 2024

Thanks for replying so fast! Unfortunately it didn't work.

from require-css.

andreu86 avatar andreu86 commented on August 12, 2024

Sorry, I was wrong, it works. Thank you! Will you include a definitive fix in css-builder.js? Thanks ;)

from require-css.

guybedford avatar guybedford commented on August 12, 2024

So it was those lines? Ok I've added a fix that is more compatible. Please let me know if you notice any issues with this.

from require-css.

guybedford avatar guybedford commented on August 12, 2024

I haven't been able to test this, but I am assuming it has been fixed to release 0.0.1. If there is still an issue please let me know asap.

from require-css.

andreu86 avatar andreu86 commented on August 12, 2024

It's still there, it didn't fix it.

from require-css.

guybedford avatar guybedford commented on August 12, 2024

Any chance you can share a test project / repo for me to try this out?

from require-css.

andreu86 avatar andreu86 commented on August 12, 2024

I tried to create a test project, but it worked... then I found what was going on, I was minifying the JS files after the optimization, in a separate process, and that was causing the issue. The rare thing (at least for me, maybe you have a clue) is that commenting out the piece of code you told me it works, but with your final solution it doesn't...

from require-css.

guybedford avatar guybedford commented on August 12, 2024

So if I understand you correctly, the grunt process itself is running fine, it is simply that the app isn't running after minification? If so have you tried relaxing the uglification settings? Or is it the grunt process itself that is stalling?

from require-css.

guybedford avatar guybedford commented on August 12, 2024

I'm closing this for now. If you have any further issues please let me know.

from require-css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.