Comments (6)
Hey @guillaume-be, are you asking me to add tests to the cached-path
crate? We have already some tests here: https://github.com/epwalsh/rust-cached-path/blob/master/src/cache.rs#L433
from rust-bert.
Hi @epwalsh nice crate and seems to align well with the current resources downloader. The check for Etag and file locks is a nice addition.
I am trying to be mindful of the dependencies pulled in the project. I see you are relying on the failure
crate which has been deprecated for a few months now. Is there any way you could rely instead on the thiserror
crate for your API error handling, and anyhow
for dev/examples?
from rust-bert.
Hey @guillaume-be, yeup, that sounds good. Didn't realize failure
has been deprecated.
from rust-bert.
Just made a PR to switch over: epwalsh/rust-cached-path#18
from rust-bert.
@epwalsh Thank you - this looks good. I also noticed that the crate currently does not have further dependencies - which is fine on my side. Because of this I believe a good unit test and integration test coverage would be extremely helpful. Could you please add test for key functionalities of the crate (e.g. file lock, cache corruption, Etag check) in either unit or integration tests and add them to the CI?
from rust-bert.
Sorry I missed those!
from rust-bert.
Related Issues (20)
- Does the marian model have a method like huggingface generate? HOT 4
- Fine-tuning Marian model can't use pipeline doing translate task HOT 2
- When label mapping aren't provided - we get a crash HOT 1
- Zeroshot with DeBerta v2 vs BART - is it worth it? HOT 2
- Can I use this lib with onnx but without libtorch? HOT 1
- how to use Cross-Encoder for MS Marco by rust-bert?
- Seek Assistance and Support for DeBERTa Model HOT 2
- Is multilabel prediction correct? HOT 1
- Evaluation fails when trying to extract keywords from a specific sentence HOT 2
- Please expose tonekizer params on models where `forward_t` is exposed
- Downloading a model to a local Directory HOT 4
- Question: Configuring ZeroShotClassificationModel with DeBERTaV2 - Documentation HOT 1
- Upgrade Cargo dependencies HOT 2
- GPT-2 text generation throws an unexpected error HOT 4
- Any plan to release a new version? HOT 2
- Question: is it ok to continue after OOM error from `encode`
- update to be working with torch 2.2.0
- support for huggingface access token
- Error on running example in Linux
- RemoteResource doesn't allow loading safetensors models
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-bert.