Comments (6)
Tried to remove the preference for enabling/disabling sound, leaving only the picker.
from facebooknotifications.
It's not redundant, keep it back. because there will be long list of ringtones in picker, every time the user has to pick his favorite ringtone to enable / disable ringtones.
the picker will save user's favorite ringtone.
the checkbox will turn on/off sound temporarily or permanently without having to select ringtone again
It was related to me, why did you close before i reply.
from facebooknotifications.
Yes, there may be a long list of ringtones, but the "None" is always at the top of the list, next to "Default" one. I open this issue for all Android users, to check if this option exists everywhere, which is the case.
What happens for the user if he enabled the sound notification but hears nothing? It seems to be a bug, but it is because he muted them twice: once with the checkbox, once with the "None" ringtone. I have checked my apps and the vast majority offer only the ringtone picker (K9 Mail, Conversations, Google Hangouts to name a few).
I want to keep the app as simple and lean as possible without decreasing the functionalities and the current setup is OK for that. The only drawback is for persons changing the ringtone several times a day. It's for the very same reason that I do not plan to add a user-defined vibration pattern, except if I get a lot of request to be able to customize it.
As Einstein may have said, everything should be made as simple as possible, but no simpler.
EDIT: I must say that I appreciate a lot your contribution as it is solving some opened issues without overhead. Thanks!
from facebooknotifications.
Cool dude, no need of such a big reply.
from facebooknotifications.
I just wanted not to seem harsh, so I carefully explained everything :)
from facebooknotifications.
good
from facebooknotifications.
Related Issues (20)
- disable synchronization not working HOT 2
- Changing Orientation Causes the Page to Reload HOT 2
- INVALID
- Add button to share current url on Facebook via app itself
- Choose version of Facebook site? HOT 1
- Handle better the notification update when several categories are present
- Add diagnosis data
- NullPointerException on menu tap under certain circumstances HOT 1
- Option to forcefully show the current number of notifications
- Option to show that there are no notifications waiting at all
- Display the number of pending notifications on the status bar
- When messages are waiting, try to find out from where they come from HOT 1
- Ask to disable energy savings for Android 6+
- Possibility to make the notification persistent with a "Refresh button"
- Lighterweight page found to load
- can't zoom on event description HOT 1
- Allow alternate upload types in messages HOT 3
- Messaging no longer supported HOT 5
- Add a homescreen widget HOT 1
- Req: notification for message requests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from facebooknotifications.