Comments (5)
Btw, my workaround for this is to create a newtype around an Arc<RwLock>
, so i don't actually give the socket to ggrs
from bevy_ggrs.
Thanks for reporting, I'd like a convenient way to do this as well.
I think it's best if session starting and closing mirrors each other. So perhaps best to change how we start from inserting a resource to commands as well. Perhaps:
let session = session_builder
.start_p2p_session(socket)
.expect("failed to start session, check config");
commands.start_session(session);
Or perhaps take a session_builder and socket instead?
commands.start_p2p_session(session_builder, socket);
from bevy_ggrs.
I think it's best if session starting and closing mirrors each other. So perhaps best to change how we start from inserting a resource to commands as well. Perhaps:
let session = session_builder .start_p2p_session(socket) .expect("failed to start session, check config"); commands.start_session(session);
That would be a nice abstraction. Would it be possible to have the socket returned to us when we end the session? Something like:
let socket = commands.end_p2p_session()
.expect("failed to return socket");
from bevy_ggrs.
Not with commands, no. It could perhaps be put into a resource where we could collect it... Not the nicest api, though
from bevy_ggrs.
Not with commands, no. It could perhaps be put into a resource where we could collect it... Not the nicest api, though
Yeah, that sounds pretty ugly. I like your idea of having the api work entirely thru commands
, but perhaps there could be a separate way to take the socket which would make the session inactive until we clean it up via commands
. Though that's probably a separate Issue.
let socket = session.take_socket();
commands.end_p2p_session();
from bevy_ggrs.
Related Issues (20)
- [Question] How to sync elapsed time since startup among peers? HOT 4
- 3d example, and other questions HOT 4
- Update entity IDs in Children/Parent components on rollback. HOT 2
- Update to Bevy 0.13
- Document idiomatic way to sort rollback related queries
- Synctest session doesn't detect all desyncs that it could/should
- Adding players after p2p session already started HOT 3
- Support synchronizing parts of world state, since Rust isn't deterministic. HOT 15
- Potential Scalability Refactor HOT 6
- Sessions `.with_desync_detection(DesyncDetection::On)` always reports false positives HOT 1
- Integration Tests incorrect HOT 2
- More idiomatic component/resource checksums for float types?
- Adding non-rollbacked children to rollbacked entities break the hierarchy HOT 1
- Desync detection appears to compare the checksum of predicted frames to confirmed frames HOT 8
- Sprite Component doesn't get respawned after rollback HOT 5
- panic: `Rollback requested was not created using AddRollbackCommand!`
- When rollbacks happen across entity spawning, desyncs are reported HOT 1
- Despawned entities are not restored HOT 2
- Checksums are not portable HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bevy_ggrs.