Coder Social home page Coder Social logo

Comments (18)

KAClough avatar KAClough commented on September 11, 2024 1

LinMom -> LinearMomentum (its not so long!)

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1
  • Comments around RHS in Level.cpp classes are out of date (e.g. about setting constraints to zero)
  • specificPostTimeStep needs to be better commented

from grdzhadzha.

SamuelBrady avatar SamuelBrady commented on September 11, 2024 1
  • ScalarPotential.hpp and ComplexScalarPotential.hpp classes should be moved from Source/Matter to relevant examples

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

The TaggingCriterion -> FixedBackgroundTaggingCriterion - just use the one in GRChombo?

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

Both examples have a constant field value as the initial conditions - consider making one a gaussian or something more interesting (probably the real SF one)

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

Is emtensor_t being duplicated from GRChombo?

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

Check header guards as per James. Also copyright should be 2023.

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

do_I_excise -> is_excised

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

https://github.com/GRChombo/GRChomboFixedBackground/blob/main/Source/Background/BoostedKerrSchildBH.hpp seems to contain BoostedBH class, so need to rename. Paper reference also seems to be wrong - has this been tested? Maybe just remove if not used in the examples.

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

Simplify the extraction reading in https://github.com/GRChombo/GRChomboFixedBackground/blob/main/Source/Background/FixedBGSimulationParametersBase.hpp since most params not used - especially for modes etc. which refer to GWs.

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

excise returns a double in the function definition but returns a bool in the body.

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

we could actually make excise templated over data_t using auto

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

The conservation things use the normalised normal vector, but we should be able to remove both this and the dArea (since they cancel out)

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

The params for the KerrBH specify symmetry in y and z but it should only be in z

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

Missing the python output file for the Kerr example

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

There is a problem in the GNUMakeFile in the base directory - GRChombo source is specified but should not be

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

The data is not output to the data folder

from grdzhadzha.

KAClough avatar KAClough commented on September 11, 2024 1

The plot of energy conservation has some sign issues - maybe in the definition of rho

from grdzhadzha.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.