Comments (4)
Two major reasons:
- To support streaming, we need to be able to read the partial data being sent from the server (with the
Transfer-Encoding: chunked
HTTP header). But for now, the underlying XHR implementation does not support reading partial binary data. See https://hpbn.co/xmlhttprequest/
Partial response can be read only from the responseText attribute, which limits us to text-only transfers. There is no way to read partial response of a binary transfer.
- We sent trailing metadata as a separate message at the end, basically using the same
Transfer-Encoding: chunked
mechanism. We don't want to have to wait for the entire trailers to be sent before the client can read the 'response'.
from grpc-web.
Ok, the reading about XHR is interesting, I understand better now.
Regarding your second point, could you be more specific when saying
"sending trailing metadata as a separate message at the end"
Because in this other thread, I'm trying to manually decode the base64 response to a protobuf message. I correctly receive the whole response (as a base64 string), but when deserizalizing, I get all the data in the same Message field, with many scrambled character...
Could it be the result of these metadata being mixed with the protobuf message response?
Many thanks!
from grpc-web.
@stanley-cheung please talk to @MarcusImprobable. We solved it using xhr.responseType = "text"
and this magical byte mapping hack:
https://github.com/improbable-eng/grpc-web/blob/master/ts/src/transports/xhr.ts#L4
Seems to work on Safari, which is the new IE ;)
from grpc-web.
@sulliwane The current github release is a pre-alpha release, with the core shared with our internal release. If you don't mind, let's focus on the API (feedback) rather than the implementation detail for the JS client (which will be updated frequently before beta).
Thanks for all the feedback!
===
@mwitkow Yes, I have looked at this and we will evaluate the xhr hack which would be a great optimization. We also need make grpc-web client works across all browsers (inc. mobile browsers).
Re: base64, it is also required for serving binary responses from cookie domains (to prevent XSS etc).
from grpc-web.
Related Issues (20)
- Compile & run helloworld: protoc-gen-js: Plugin failed with status code 126 HOT 1
- Status of streaming with the binary wire format HOT 4
- Client reconnection to long-running poll HOT 1
- Trailer metadata - repeated values only supported with "trailers-only" responses HOT 3
- Roadmap.md needs updating HOT 4
- Are there any plans to simplify the request HOT 2
- Is there a proto-loader for gRPC-web? HOT 2
- Please ignore...
- > It's working for grpc-web + protobuf.js. I hope it helps somebody. HOT 2
- stream.cancel doesn't close the stream HOT 2
- Why optional message types compile inconsistently? HOT 5
- Closure Migration & Typescript-ification HOT 4
- Grpc-web not return exactly grpc status always response 2 Incomplete response HOT 7
- Why generated files doesn't have implemented classes? HOT 2
- Difficulty building under Alpine 3.19 HOT 1
- How to connect a docker-run Go gRPC server to a React app?
- Client does not report correct error codes per the spec for HTTP status code mapping HOT 1
- Compression handling uses wrong error codes HOT 1
- Cardinality violations should use error code “unimplemented” HOT 2
- gRPC errors in nice-grpc-web come back as undefined in angular 18 in optimized builds with zonejs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-web.