Comments (8)
Before we enforce revive, we need to fix existing lint issues caught in #7472 as part of vet check.
Its fine to change several files in a single PR if they all fix one type of issue or are otherwise related. However, be reasonable and try to keep the PRs small enough to make it not take a long time to review and avoid merge conflicts.
from grpc-go.
@purnesh42H Please assign me this issue.
from grpc-go.
@purnesh42H Right now, In the tests (vet) I'm getting like don't use an underscore in package name https://revive.run/r#var-naming.
It's not expecting underscore but by default as it's generating from the proto file like ("google.golang.org/grpc/reflection/test/grpc_testing_not_regenerate"). So, what need to do for further. Please suggest.
from grpc-go.
@purnesh42H Fixed some of the godoc-linter issues. Please review and let me know if any changes are required. Please find the PR below.
#7501
from grpc-go.
@purnesh42H Fixed linter issues for superfluous-else, increment-decrement, indent-error-flow, var-declaration. Please review the changes.
from grpc-go.
@purnesh42H Fixed below godoc linter issues. Please find the PRs below. Please let me know if any changes are required.
15 redefines-builtin-id
8 package-comments
8 empty-block
6 var-declaration
3 indent-error-flow
2 increment-decrement
1 superfluous-else
janardhanvissa#1
janardhanvissa#2
janardhanvissa#3
from grpc-go.
@purnesh42H Fixed linter issues for superfluous-else, increment-decrement, indent-error-flow, var-declaration. Please review the changes.
Thanks. LGTM. Please open the. PR in main repo.
from grpc-go.
@purnesh42H Fixed below godoc linter issues and raised a PR to main repo.
6 var-declaration
3 indent-error-flow
2 increment-decrement
1 superfluous-else
from grpc-go.
Related Issues (20)
- How to make server-stream run in a non-blocking state and handle other requests HOT 10
- Improve Logger Performance When Disabled HOT 5
- Flaky Test: RingHash_ReattemptWhenGoingFromTransientFailureToIdle
- xdsclient: reduce the number of ADS requests
- grpctest: minor improvements to the test logger implementation
- xdsclient: support environment variable protection for fallback
- Incorporate `mem` package into custom HTTP/2 Framer
- Examples using the `experimental` stats package HOT 2
- about grpc.NewClient,It will not check the validity of the target ? HOT 1
- Minor typos HOT 7
- clientconn: Subconn state may transition from CONNECTING directly to IDLE HOT 1
- Flaky Test: Balancer_TwoAddresses_WeightExpiration HOT 1
- Add a test for scenarios touched in 7505
- RetryPolicy backoff value being randomized makes no sense compared to C++ reference client HOT 2
- pickfirst: Don't use internal.ShuffleAddressListForTesting directly HOT 1
- grpc usage on unix sockets: strange grpc registry behaviour
- Question about option experimental.WithRecvBufferPool
- Flake: Test/BlockingPickSCNotReady
- Valid allow-all Authz Policy return permission denied
- bug: `FATAL: [core] grpc: Server.RegisterService found duplicate service registration for "grpc.health.v1.Health"`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-go.