Coder Social home page Coder Social logo

Add godoc linter about grpc-go HOT 8 OPEN

dfawley avatar dfawley commented on August 18, 2024
Add godoc linter

from grpc-go.

Comments (8)

purnesh42H avatar purnesh42H commented on August 18, 2024

Before we enforce revive, we need to fix existing lint issues caught in #7472 as part of vet check.

Its fine to change several files in a single PR if they all fix one type of issue or are otherwise related. However, be reasonable and try to keep the PRs small enough to make it not take a long time to review and avoid merge conflicts.

from grpc-go.

janardhanvissa avatar janardhanvissa commented on August 18, 2024

@purnesh42H Please assign me this issue.

from grpc-go.

janardhanvissa avatar janardhanvissa commented on August 18, 2024

@purnesh42H Right now, In the tests (vet) I'm getting like don't use an underscore in package name https://revive.run/r#var-naming.
It's not expecting underscore but by default as it's generating from the proto file like ("google.golang.org/grpc/reflection/test/grpc_testing_not_regenerate"). So, what need to do for further. Please suggest.

from grpc-go.

janardhanvissa avatar janardhanvissa commented on August 18, 2024

@purnesh42H Fixed some of the godoc-linter issues. Please review and let me know if any changes are required. Please find the PR below.
#7501

from grpc-go.

janardhanvissa avatar janardhanvissa commented on August 18, 2024

@purnesh42H Fixed linter issues for superfluous-else, increment-decrement, indent-error-flow, var-declaration. Please review the changes.

janardhanvissa#1

from grpc-go.

janardhanvissa avatar janardhanvissa commented on August 18, 2024

@purnesh42H Fixed below godoc linter issues. Please find the PRs below. Please let me know if any changes are required.

15 redefines-builtin-id
8 package-comments
8 empty-block
6 var-declaration
3 indent-error-flow
2 increment-decrement
1 superfluous-else

janardhanvissa#1
janardhanvissa#2
janardhanvissa#3

from grpc-go.

purnesh42H avatar purnesh42H commented on August 18, 2024

@purnesh42H Fixed linter issues for superfluous-else, increment-decrement, indent-error-flow, var-declaration. Please review the changes.

janardhanvissa#1

Thanks. LGTM. Please open the. PR in main repo.

from grpc-go.

janardhanvissa avatar janardhanvissa commented on August 18, 2024

@purnesh42H Fixed below godoc linter issues and raised a PR to main repo.

6 var-declaration
3 indent-error-flow
2 increment-decrement
1 superfluous-else

from grpc-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.