Comments (5)
All I have to do to make it work is put a dummy ":kludge" suffix on the address, and strip it out in my TransportAuthenticator.Dial. But that really shouldn't be necessary ;)
from grpc-go.
This is not sufficient because it does not work in the case when there is no TransportAuthenticator (i.e., plain TCP). Plus, how does the client lib differentiate a malformed host:port address (e.g. a user passed an IP addr and forgot setting the port) and real unix socket domain name if we allow users pass an arbitrary string. My idea is to make things explicit. For example, if users want to use UDS, they need to specify the protocol explicitly when creating the transport. This approach is also scaling when we want to support more transport protocols.
from grpc-go.
Oh, absolutely. I am abusing the TransportAuthenticator point to hook up a custom dialer; proper custom dialer support would definitely be better.
Oh and just to be clear, just passing "network, addr string" to net.Dial would cover the unix domain socket part, but still leave out all the things that are truly custom transports, e.g. reliable stream transports over UDP.
from grpc-go.
Agree, those kind of transports (e.g., QUIC, RDMA, etc.) need the native support from the underlying library (e.g., Go net package).
from grpc-go.
closed via #169
from grpc-go.
Related Issues (20)
- Flaky test: Test/AggregateCluster_BadDNS_GoodEDS HOT 3
- Setting HTTPS proxy without setting HTTPS_PROXY env variable HOT 2
- channelz has a startup sequencing bug HOT 2
- ring_hash stuck in TransientFailure despite having available endpoints HOT 1
- Flaky Test/AuthorityRevive in google.golang.org/grpc/xds/internal/xdsclient/tests HOT 3
- Implement Custom Types for gRPC-Go Framer HOT 1
- xds: implement ADS stream flow control mechanism
- xds/csds: unskip test after ADS stream flow control changes are merged
- 'use of closed network connection', what's the best practice to deal with this? HOT 7
- Infinite loop in bufWriter.Write() HOT 6
- metadata: MD.String should only show metadata known to not contain tokens or other PII HOT 1
- Over 300+ groutines after only a few minutes of testing HOT 6
- Allow client-side access to `grpc-status` and `grpc-message` HOT 2
- scripts: fixes/improvements to regenerate.sh / install_protoc.sh
- Surface response body when receiving an unexpected status code and content-type HOT 1
- Default fallback scheme changed from `passthrough` to `dns` HOT 2
- Support for custom code check HOT 2
- grpc: error unmarshalling request: failed to unmarshal, message is X, want proto.Message HOT 1
- Is it ok to call grpc.UnaryInvoker multiple times inside an interceptor? HOT 7
- Flaky Test: AllMetricsOneFunction
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-go.