Comments (20)
i can do the second and the third task, but for the third one, i'll need more information about what should be in MealForm component
from calendar.
Ok, let's start from second task
from calendar.
Story:
Previosly, most part of this funcitonality was done by Sanchit - while he learned how to code at React.
At some point, we decided to split code, that was made into a few chunks. My aim was to separate meal calendar and work on it as standalone module. it helps us to make it clean, try different approaches, etc.
AddMealForm is a file, that was used at Sanchit project. And we move it only for one reason - without this component - our project will be broken(because our previous project structure was not ideal, but ok).
Actually, at this stage of calendar module - we don't need this form. So main idea was to remove this component. But not just delete it and forget about it. You should be aware and check whole project. because if you just delete this file - it'll break the project - you should prevent it and clean up our code.
tell me if something is not clear @GuiFSs
from calendar.
so, the file AddMealModal.js in the project will be in another module and should be deleted from this one, but i have to make sure that when i delete it, it won't break the project, but for what i saw, this file is not been used in any other component, so i think it won't be a problem
from calendar.
yes, you're right, but i'm not sure if it not used anywhere
from calendar.
ok so, i was testing the "switch mode" button, and i found an error when we get a dish by week, should i open a issue and try to figure it out the problem? i think it's because the function getRandomWeek in WorkSchedule.js file
from calendar.
yes, please open an issue and explain it here. it'll help us in future
from calendar.
Please follow this link https://github.com/GroceriStar/calendar/invitations
from calendar.
Please follow this link https://github.com/GroceriStar/calendar/invitations
sorry to ask, but what is this for?
from calendar.
you can read it by URL :) want to add you to collaborators, so i can assign tasks at this repo for you
from calendar.
@GuiFSs let's discuss here what else we can do at this project right now. Do you have any ideas?
from calendar.
i'm curious to see your ideas about how we can improve it
from calendar.
ok, but first i would like to know more about the main function of calendar, i mean, correct me if i'm wrong, the objective of calendar is to show the users, suggestions about helthy meals, ingredients, etc, in a certain day and time, so the user can keep it organized and have a better diet
from calendar.
right now is more simple than you think. Maybe later we'll evolve it, but for now - main goal of this project is to give an ability to people see meal plans(i.e. meals/recipes) per days.
Nothing more nothing less. This repository is our sandbox. Where we testing different layouts, different components that we can use.
When we'll make the code of it clean - we'll be able to add this module to our projects.
from calendar.
well, the only thing i can think now is to have a way of people share this meal plans, i think this is a good way bring more people to the site. But i don't know if this is too complex right now
from calendar.
yeah, i like your idea. will add it to our feature list. and yes - it's not a simple thing
from calendar.
@GuiFSs do you have other tasks?
from calendar.
@atherdon actually i don't have
from calendar.
https://github.com/GroceriStar/react-shopping-list-template/issues/67
GroceriStar/react-shopping-list-template#66
please grab something from here - but notify what you'll take. we are with Vadim working on it too
from calendar.
@GuiFSs tell me if you need help with this task from that repo or if you busy at college - so i'll be able to assign it to someone else
from calendar.
Related Issues (20)
- html calendars
- use react modal?
- replace with our grocery-component
- enzyme shallow tests
- Sanchit comments HOT 6
- discussion about making it responsive HOT 2
- renderer Method re-ogranization. Refactoring HOT 10
- add this button
- at this pull i saw a lot of strange things
- Link HOT 4
- Switch Mode button throwing an error sometimes HOT 8
- One Modal window to rule em all
- tasks HOT 1
- (Feat) Share Meal plans
- Dependency Dashboard
- redo calendar grid
- move selector away from components folder
- remove Display List component - because we have it in our separated module
- calendar/src/components/RenderModal/RenderModal.js - connect our List component HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from calendar.