Bad rpm spec file about grive

[nestal]

Can you tell me what's the different? I don't know much about rpm specs.

[Vascom]

1. Not needed some BuildRequires, because them installed as dependencies for other:
   BuildRequires:libstdc++-devel
   BuildRequires:json-c-devel
   BuildRequires:openssl-devel
   BuildRequires:expat-devel
   BuildRequires:cppunit
   BuildRequires:libcurl-devel

But needed
BuildRequires: boost-devel
BuildRequires: cmake

1. Requires not needed at all. Them maked automatically by rpmbuild.
2. Build section better use macros:
   %build
   %cmake .
   make %{?_smp_mflags}
3. Postinstall ldconfig must be executed:
   %post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

1. In section %files all standart path must be macros. It needed for i686 and x86_64 builds because them use different lib path /usr/lib/ and /usr/lib64/ :
   %files
   %doc COPYING README
   %{_bindir}/%{name}
   %{_libdir}/libgrive.so.*
2. All headers and devel files must be in separate subpackage grive-devel:
   %files devel
   %{_includedir}/%{name}*
   %{_libdir}/libgrive.so

Thats all. I think this is enough.

[nestal]

OK. I will merge it.
On Jun 5, 2012 1:08 PM, "Vasiliy Glazov" <
[email protected]>
wrote:

1. Not needed some BuildRequires, because them installed as dependencies
   for other:
   BuildRequires:libstdc++-devel
   BuildRequires:json-c-devel
   BuildRequires:openssl-devel
   BuildRequires:expat-devel
   BuildRequires:cppunit
   BuildRequires:libcurl-devel

But needed
BuildRequires: boost-devel
BuildRequires: cmake

1. Requires not needed at all. Them maked automatically by rpmbuild.
2. Build section better use macros:
   %build
   %cmake .
   make %{?_smp_mflags}
3. Postinstall ldconfig must be executed:
   %post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

1. In section %files all standart path must be macros. It needed for i686
   and x86_64 builds because them use different lib path /usr/lib/ and
   /usr/lib64/ :
   %files
   %doc COPYING README
   %{_bindir}/%{name}
   %{_libdir}/libgrive.so.*
2. All headers and devel files must be in separate subpackage grive-devel:
   %files devel
   %{_includedir}/%{name}*
   %{_libdir}/libgrive.so

Thats all. I think this is enough.

---

Reply to this email directly or view it on GitHub:
https://github.com/match065/grive/issues/44#issuecomment-6117670

[nestal]

Do we need to put the git commit SHA in the release string? Is it a standard practice in all fedora packages? I don't remember seeing an SHA in rpm filenames...

[Vascom]

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
It not nesessary, but may be:
For instance, if you create a snapshot from a git repository on January 2, 2011 with git hash 9e88d7e9efb1bcd5b41a408037bb7cfd47220a64, %{checkout} string could be any of the following:

20110102snap
20110102git
20110102git9e88d7e

[nestal]

I am not interested in doing snapshot builds in RPM formats right now. I plan to only build RPMs for milestone releases only (e.g. v0.1.0). Can I use 0.1.0 as the release part in the RPM file?

Grateful if you can modify the spec file before I merge it.

[Vascom]

OK. I'll modify it.

[nestal]

Thanks!

[Vascom]

Done
https://github.com/RussianFedora/grive/blob/master/grive.spec

[Vascom]

I will try to become a maintainer package in Fedora.