grive temp file "p" being uploaded about grive

[OpenNingia]

this issue seems similar to the one I reported ==> #26

[sgbeal]

i looked at that, but it's not quite a duplicate. Grive "shouldn't" be using the name "p" in that dir at all for a temp file name because i might have a file named "p", which it would then nuke. If grive is going to go with the policy of not synching dot-files, then it needs to name temp files with a dot or put all of its state in a single .grive directory (that would be my preferred solution, since it probably means less maintenance and hassle long-term).

Edit: but the uploading of the grive binary is of course related to point (b).

[OpenNingia]

what about handling some sort of .grive_ignore file ( as git does ) ?

[sgbeal]

i think "the right(er) thing" would be a .gdrive directory and store all grive-internal files there. It's future-proof, easy for a client to get rid of, and leaves less crud in the synced root.

[OpenNingia]

yes, I agree

[match065]

Where does 'p' come from? I don't remember writing code that create a temp file called 'p'. Is it a bug?

Currently grive already has a .grive file to store the login credential. How about putting the ignore list in .grive also?

I don't plan to have many grive internal file that requires a .grive-internal directory. Now grive has two internal files: .grive to store the credential, and .grive_state to store the state of last sync.

Can you guys help writing the code that puts the ignore list in .grive? Grive checks the dot-files in Drive.cc. We can put the checking there.

[sgbeal]

i unfortunately don't know where p came from. It was full of what looked like (IIRC) POST data for an HTTP request (including HTTP headers, IIRC), but i only gave it a cursory glance. Maybe a temp file created by the HTTP client? i unfortunately rm'd it instead of setting it aside. :/

i unfortunately cannot commit to coding for the near future, but i hope to be able to hassle you guys with more bug reports :). This weekend is a 3-day weekend, so maybe i can find some time/energy to unwind in Drive.cc :).

[match065]

It's fine. You have been a great help with bug reports. I really appreciate that.

The 'p' maybe left by some debug code I wrote but forgot. If you see any of these debug log files please report it as bugs :)

[lornix]

Using GIT master (commit 6d50a0f)

The 'p' comes from grive/src/main.cc, around line 101:

case 'l' :
{
    std::auto_ptr<LogBase> file_log(new log::DefaultLog(optarg)) ;
    file_log->Enable( log::debug ) ;
    file_log->Enable( log::verbose ) ;

If you start the program with an option of '--help', as we all might do, the '-', 'h' and 'e' are ignored and give an error message, but the 'l' is accepted, and uses the NEXT object as the filename for the logs.... 'p'.

[sgbeal]

That would explain it. i did try --help, -help, -?, and -h a time or two.

[nestal]

Thanks Iornix! That clears the picture! I guess it's can be closed?

[sgbeal]

i considered closing it earlier, but the bug is apparently still there. Who doesn't run an app with --help the first time (and then continue to try -? if --help doesn't work)?

i am trying to pull the latest grive to try it out, but:

[stephan@host:~/cvs/grive]$ git pull
fatal: https://github.com/match065/grive.git/info/refs not found: did you run git update-server-info on the server?

i have no idea what that means (i'm not a git acolyte).

[nestal]

I have moved the repository. See the announcement here: https://groups.google.com/forum/#!topic/grive-devel/O-aFVSNSbn8

You can open your .git/config file, change "match065" to "Grive" in the URL and pull again.

[sgbeal]

After doing so:

[ 41%] Building CXX object libgrive/CMakeFiles/grive.dir/src/protocol/OAuth2.cc.o
/home/stephan/cvs/grive/libgrive/src/protocol/OAuth2.cc: In member function ‘void gr::OAuth2::Auth(const string&)’:
/home/stephan/cvs/grive/libgrive/src/protocol/OAuth2.cc:67:36: error: no matching function for call to ‘gr::http::CurlAgent::Post(const string&, std::string&, gr::http::JsonResponse_)’
/home/stephan/cvs/grive/libgrive/src/protocol/OAuth2.cc:67:36: note: candidate is:
/home/stephan/cvs/grive/libgrive/src/http/CurlAgent.hh:55:7: note: virtual long int gr::http::CurlAgent::Post(const string&, const string&, gr::http::Receivable_, const gr::http::Header&)
/home/stephan/cvs/grive/libgrive/src/http/CurlAgent.hh:55:7: note: candidate expects 4 arguments, 3 provided
/home/stephan/cvs/grive/libgrive/src/protocol/OAuth2.cc: In member function ‘void gr::OAuth2::Refresh()’:
/home/stephan/cvs/grive/libgrive/src/protocol/OAuth2.cc:104:36: error: no matching function for call to ‘gr::http::CurlAgent::Post(const string&, std::string&, gr::http::JsonResponse_)’
/home/stephan/cvs/grive/libgrive/src/protocol/OAuth2.cc:104:36: note: candidate is:
/home/stephan/cvs/grive/libgrive/src/http/CurlAgent.hh:55:7: note: virtual long int gr::http::CurlAgent::Post(const string&, const string&, gr::http::Receivable_, const gr::http::Header&)
/home/stephan/cvs/grive/libgrive/src/http/CurlAgent.hh:55:7: note: candidate expects 4 arguments, 3 provided
make[2]: *** [libgrive/CMakeFiles/grive.dir/src/protocol/OAuth2.cc.o] Error 1
make[1]: *** [libgrive/CMakeFiles/grive.dir/all] Error 2

[stephan@host:~/cvs/grive]$ gcc --version
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3

[nestal]

See #57 & #58. Sorry for messing it up.