Coder Social home page Coder Social logo

patch: add libnotify support about grive HOT 9 CLOSED

OpenNingia avatar OpenNingia commented on July 21, 2024
patch: add libnotify support

from grive.

Comments (9)

match065 avatar match065 commented on July 21, 2024

Thanks for the patch! inotify support is very much needed now.

Why do we need to link with gdk pixbuf?

from grive.

match065 avatar match065 commented on July 21, 2024

Also, please use tab for indentation. Please set tab width to 4.

See the wiki for the rules:
https://github.com/match065/grive/wiki

from grive.

match065 avatar match065 commented on July 21, 2024

Sorry that I have to revert the patch. I can't get it compile without libinotify.

from grive.

OpenNingia avatar OpenNingia commented on July 21, 2024

gdk pixbuf is needed because notifies uses it to render the icons. Of course you need libnotify to compile, I have no clue of how to make that an optional dependency.

from grive.

OpenNingia avatar OpenNingia commented on July 21, 2024

Howdy! here is my second attempt! In this patch I've

  • pulled your last commits from origin
  • changed spaces into tabs ( width 4 )
  • made libnotify optional using a cmake switch
    to enable libnotify support run
    cmake -DWANT_NOTIFY=1 ..

from grive.

match065 avatar match065 commented on July 21, 2024

Oh... I mean I want inotify, not libnotify.

Inotify is a library to tell us which file is created/modified.
http://www.kernel.org/pub/linux/kernel/people/rml/inotify/README

I googled libnotify, and found that it is about desktop notification. That is also useful, but I wouldn't put it in libgrive. I would prefer to have a separate executable (maybe call it grive_notify?) to use both libgrive and libnotify to notify the desktop. libgrive should be independent of GUI and desktop environments.

from grive.

match065 avatar match065 commented on July 21, 2024

I think putting the libnotify code in the "grive" executable is also OK. No need to have a separate executable.

from grive.

OpenNingia avatar OpenNingia commented on July 21, 2024

ok but then libgrive should communicate the grive executable about events to notify

from grive.

match065 avatar match065 commented on July 21, 2024

I will close this one first. Let us discuss a good interface between libgrive and grive later.

from grive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.