Comments (9)
Thanks for the patch! inotify support is very much needed now.
Why do we need to link with gdk pixbuf?
from grive.
Also, please use tab for indentation. Please set tab width to 4.
See the wiki for the rules:
https://github.com/match065/grive/wiki
from grive.
Sorry that I have to revert the patch. I can't get it compile without libinotify.
from grive.
gdk pixbuf is needed because notifies uses it to render the icons. Of course you need libnotify to compile, I have no clue of how to make that an optional dependency.
from grive.
Howdy! here is my second attempt! In this patch I've
- pulled your last commits from origin
- changed spaces into tabs ( width 4 )
- made libnotify optional using a cmake switch
to enable libnotify support run
cmake -DWANT_NOTIFY=1 ..
from grive.
Oh... I mean I want inotify, not libnotify.
Inotify is a library to tell us which file is created/modified.
http://www.kernel.org/pub/linux/kernel/people/rml/inotify/README
I googled libnotify, and found that it is about desktop notification. That is also useful, but I wouldn't put it in libgrive. I would prefer to have a separate executable (maybe call it grive_notify?) to use both libgrive and libnotify to notify the desktop. libgrive should be independent of GUI and desktop environments.
from grive.
I think putting the libnotify code in the "grive" executable is also OK. No need to have a separate executable.
from grive.
ok but then libgrive should communicate the grive executable about events to notify
from grive.
I will close this one first. Let us discuss a good interface between libgrive and grive later.
from grive.
Related Issues (20)
- cd ../google_drive/ HOT 2
- Compiling and installing in Debian (LinuxMint Debian Edition) HOT 1
- Grive deleted files when storage reached its maximum HOT 1
- Error when running grive -a HOT 1
- Automatic syncing HOT 1
- User Rate Limit Exceeded HOT 1
- Delete remote, local deleted. and destination folder HOT 1
- grive -s fails complaining of inability to connect to port 443 of google authentication server HOT 1
- Stuck at "Reading remote server file list" on first use HOT 3
- HTML files are not synced very well HOT 1
- Cant set bandwidth limit while uploading files HOT 1
- Issues with building in the readme: Unmet build dependencies: debhelper zlib1g-dev HOT 3
- How do i uninstall grive HOT 6
- Fix The Readme, it is confusing! HOT 1
- Dependency errors on Debian 9 (stretch) HOT 1
- .trash doesn't work is not same file system HOT 1
- Duplicated Files in Google Drive HOT 1
- Removing grive permissions to Google Drive HOT 1
- GRIVE NO LONGER MAINTAINED PLEASE USE GRIVE2 HOT 1
- Google has disable temporarily Grive session start HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grive.