Coder Social home page Coder Social logo

Comments (5)

felladrin avatar felladrin commented on June 11, 2024 1

That's true, it's up to the user. My suggestion was to point the users to this info somewhere in the Readme, because I assume more users will open issues related to this later on.

I think something like this in the Readme would help:

Note that this action requires permissions to read both Pull Requests and Issues from the repository. If you get an error like 'Resource not accessible by integration', please refer to this documentation or this example.

from dependencies-action.

felladrin avatar felladrin commented on June 11, 2024

@gregsdennis, please take it into account. This is some useful info to have on Readme.

In my case, here's how the workflow file ended up:

name: PR Dependency Check

on: [pull_request]

jobs:
  pr-dependency-check:
    runs-on: ubuntu-latest
    name: Check PR Dependency
    permissions:
      pull-requests: read # Reason: To check PRs for dependencies.
      issues: read # Reason: To check issues for dependencies.
    steps:
    - uses: gregsdennis/dependencies-action@main
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

from dependencies-action.

gregsdennis avatar gregsdennis commented on June 11, 2024

@felladrin I'm happy to make changes, but I'm not sure what this is asking me to do. The post seems more informational than a call to action.

from dependencies-action.

felladrin avatar felladrin commented on June 11, 2024

It's related to the RequestError [HttpError]: Resource not accessible by integration, which can happen if those permissions are not set.

image

For example, this error can occur if a person creating a PR does not have full permissions to the repository (e.g. they're just a collaborator and not an owner). So when we add the permissions directly into the workflow file, it adds the permission on-the-fly to the GitHub Token.

from dependencies-action.

gregsdennis avatar gregsdennis commented on June 11, 2024

@felladrin that's good info, but what do I need to do for this? It looks like it's something that's in the user's action.yml, not anything here. This is where I'm confused.

from dependencies-action.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.