TypeError returned when event.next_occurrence() doesn't exist. about django-eventtools

[gregplaysguitar]

Returning None sounds completely sensible to me. Feel free to make a PR, otherwise I'll get to this as soon as I have time.

[gregplaysguitar]

Just having a look at this, I couldn't reproduce the TypeError - have you got a code snippet that reproduces the problem?

[kmahelona]

I'm doing this,

(start, end, instance) = event.next_occurrence(from_date=timezone.now())

so maybe it's because my from date is in the future and the last event occurrence was in the past?

[kmahelona]

Ah ok, so if I just do,

instance = event.next_occurrence(from_date=timezone.now())

I'll get None; however doing

(start, end, instance) = event.next_occurrence(from_date=timezone.now())

raises the 'NoneType' object is not iterable error which makes sense because the code is probably trying to iterate the None instance so it can give me start and end.

I think an improvement would be to return (None, None, None) instead?

[gregplaysguitar]

Ah... yes that makes more sense. I don't think it should return (None, None, None) because then you wouldn't be able to do

if event.next_occurrence(from_date=timezone.now()):
    ...

It could generate a custom exception as you suggested above, but that might be getting a bit complex? I think returning None is probably best.

[kmahelona]

Got it. I'm not used to the returning of tuples ;).