Coder Social home page Coder Social logo

Filter Icon about mui-datatables HOT 22 CLOSED

gregnb avatar gregnb commented on July 18, 2024
Filter Icon

from mui-datatables.

Comments (22)

SiriLivtar avatar SiriLivtar commented on July 18, 2024 6

hi @gregnb.
First of all, thank you very much for the component. I am trying to change the search icon. I am trying to load my own SVG.
Is there any functionality to do this?

regards
luis

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

There's no option as of today to change the icons. That would be a feature request. Let me look into that.

Second issue, removing some items in the last filter. Can you show me a screenshot of what you're talking about ?

from mui-datatables.

krishnaUIDev avatar krishnaUIDev commented on July 18, 2024

Please see the screenshot. I want to remove salary from the filter. But I need that salary on the table. Not in the filters. Is there any chance???
screenshot 19 _li

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

Ok I think this is a great idea. It goes along with some other changes users have requested. Currently I'm on vacation so I will not be able to get to this rigjt away but I will look to add this feature for more customization.

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

So I have some initial work done that will allow for customization of columns. It'll also address #3 when it's complete. As it stands now you'll be able to define which columns you want filtering for or not. But, as far as the icon replacement here's what I'm proposing: You'll be able to swap in custom icons but they must be React Components that return SVG much like how material-ui-icons works currently

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

@krishnaUIDev In version 1.0.8 I've added the ability to customize columns. You can turn the filter on/off per column basis

from mui-datatables.

krishnaUIDev avatar krishnaUIDev commented on July 18, 2024

Thanks @gregnb. And if you have time can you look at removing columns from filters.

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

@krishnaUIDev yea that's what I just posted lol. You can remove them now in version 1.0.8. Take a look at the new examples folder

from mui-datatables.

krishnaUIDev avatar krishnaUIDev commented on July 18, 2024

When click on Filter Icon or view column icon its getting error @gregnb
screenshot 21

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

@krishnaUIDev looks like a warning. I think the current PR fixes it when we merge it in. But nothing is broken, correct ?

from mui-datatables.

krishnaUIDev avatar krishnaUIDev commented on July 18, 2024

Ya Nothing is broken and can you try to add functions to the rows (onClick events). Is there any chance to add onclick events to that rows? ?

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

Ok, but I want to learn more about why. What's the use case first to binding an onClick event to the rows? Are you tracking something? Just curious

from mui-datatables.

krishnaUIDev avatar krishnaUIDev commented on July 18, 2024

I am trying to create a data table site. At that place, i need to click handlers for rows to show that row data.

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

@krishnaUIDev Ok, I will try to work on expanding more options into this package. I'm still on vacation so nothing will get done right away so bare with me. If it makes sense after I look into it some more I'll put it on the feature board. Some people have also asked for ability for selectable rows which sounds close to what you're asking for

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

Selectable rows have been added in the latest version. It has two event callbacks that should help with this ticket.

from mui-datatables.

krishnaUIDev avatar krishnaUIDev commented on July 18, 2024

Is there any new features??

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

Yes, in the latest version there are selectable rows and two callbacks you can read the README for more information

from mui-datatables.

krishnaUIDev avatar krishnaUIDev commented on July 18, 2024

Thanks. And is there any chance to change font icons??

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

Nevermind that, I wrote about the wrong section this is related to toolbar. Let me think about this some more

from mui-datatables.

gregnb avatar gregnb commented on July 18, 2024

So I'm trying to find a good reason to do this but I'm struggling. The only icons I would allow are ones to be loaded from material-ui-icons package. Take for example print, if you search https://material.io/icons/ there are only two available. Were you going to try to load in your own SVG's?

from mui-datatables.

Ciip1996 avatar Ciip1996 commented on July 18, 2024

Did any of you guys have any luck by changing the icons svg? @SiriLivtar @gregnb

hi @gregnb.
First of all, thank you very much for the component. I am trying to change the search icon. I am trying to load my own SVG.
Is there any functionality to do this?

regards
luis

from mui-datatables.

entozoon avatar entozoon commented on July 18, 2024

Is it still true that you can't conveniently change the filter button content / style? (You can now at least change the icon via components={{ icons: { FilterIcon: ...

If it's helpful at all, I've managed to add text with some brutal CSS along the lines of

[data-testid^="Filters"]::after {
  content: "Filters"
}

And you could even hide the SVG and replace it with a background-image.

from mui-datatables.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.