Coder Social home page Coder Social logo

Comments (3)

saitouena avatar saitouena commented on July 28, 2024

This happens when a discarded form is a sub-expression of some form. I mean:

;; I just removed a surrounding let-form `(let [p 1] ...)` from aknorsh's example
#_(+ 1 2)

(defn hoge
  [x]
  (+ 1 2)
  )  ;; this ")" will be moved to the upper line by cljstyle

In this case, cljstyle works well. It seems to be weird.

from cljstyle.

greglook avatar greglook commented on July 28, 2024

Curious - I'll add some tests and see if I can figure out what's going on.

from cljstyle.

greglook avatar greglook commented on July 28, 2024

Huh, this was due to some incorrect handling logic in the edit-walk function. If the discarded form was the last one in the subform, then (z/right* zloc) returns nil, and the walk concludes there are no more items to visit. Instead, it should pop back up until it finds something to go right from, or hits the root again.

from cljstyle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.