Typo in greenshot.ini ? about greenshot

[Lakritzator]

I wouldn't directly call it a bug, as this is something which prevents running, but nevertheless a good find!

This actually is not easy to change, as this will break the settings for all current installations when upgrading. I would need to add upgrade code, when going from 1.2.10.6 to the next version it needs to handle the renaming.

But this issue does bring forward that for my configuration framework (Dapplo.Config) I will need to add something to assist with upgrades. This gets really hairy when upgrading from an older version (not the previous) to the current.

Thanks for the hint!

[Lakritzator]

For my future self, the typo is also in the most recent development:
https://github.com/greenshot/greenshot/blob/develop/src/Greenshot.Addons/Core/ICoreConfiguration.cs#L219

[pke]

So a potential new version will read the old key Thumnail at first start and saves its value in Thumbnail. Then the old value could be deleted from the ini.
Do I miss something?

[Christian-Schulz]

For my future self, the typo is also in the most recent development:
https://github.com/greenshot/greenshot/blob/develop/src/Greenshot.Addons/Core/ICoreConfiguration.cs#L219

as a permalink:

greenshot/src/Greenshot.Addons/Core/ICoreConfiguration.cs

Line 219 in a9b3a22

bool ThumnailPreview { get; set; }