Remove dependency to commons-lang about greenmail

[buildscientist]

@camann9 @marcelmay

How do you feel about using a library like - unbescape instead of commons-lang3?

We'd still be pulling in a dependency - but unbescape itself doesn't have any dependencies. The alternative is I pull the Java escaping specific classes out (the project is Apache 2.0 licensed) and use them in GreenMail.

[marcelmay]

Hi,

I’d rather favour to inline the method (or impl.).
Unbescape is less known than Apache commons lang, and still is >100kb.

We escape only very few < 10 elements, right?

Cheers,
Marcel

On 09 May 2015, at 21:54, Youssuf ElKalay [email protected] wrote:

@camann9 https://github.com/camann9 @marcelmay https://github.com/marcelmay
How do you feel about using a library like - unbescape http://www.unbescape.org/ instead of commons-lang3?

We'd still be pulling in a dependency - but unbescape itself doesn't have any dependencies. The alternative is I pull the Java escaping specific classes out (the project is Apache 2.0 licensed) and use them in GreenMail.

—
Reply to this email directly or view it on GitHub #51 (comment).

[buildscientist]

@marcelmay

We should be escaping pretty much anything in the IMAP envelope. I'll pull the Java escaping code in from Unbescape.

[buildscientist]

Reassigned this issue to myself as I'll be pulling in the Java escaping code from Unbescape.

[buildscientist]

@camann9 @marcelmay Please code review and approve/disapprove my PR :)