Comments (1)
Deepak, excellent work on this homework, nice job tackling the optionals. Hopefully, things with iOS are starting to come together for you. In the feedback below, I go through a checklist, and if things look good, I'll mention it to let you know you're on the right track, or I'll provide some feedback.
- TwitterClient and models look good. In production, there would be more validation to be robust to unexpected values, but in this homework it was fine to assume a well behaved API.
- You should move your assets to Images.xcassets.
- TweetCell looks good, good use of property observers, you can make the view properties private for more encapsulation.
viewWillAppear
shouldn't generally fire network requests. Instead, just reload the table data. If the data has changed, pass it back to the view controller locally. If you do need to do a network refresh, consider doing it when the app comes back from the background.- In general Auto Layout constraints look good.
from twitterapp.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twitterapp.