Coder Social home page Coder Social logo

Comments (5)

c0d0g3n avatar c0d0g3n commented on May 5, 2024 1

@kamek-pf and all others that stumble upon this issue: You can now define interfaces as a thunk. It worked for me (using [email protected] and [email protected]) and swapi-graphql is using it too.

Hope this saves some people some searching :)

from graphql-relay-js.

dschafer avatar dschafer commented on May 5, 2024

@leebyron, thoughts? This would probably be a change to https://github.com/graphql/graphql-js

from graphql-relay-js.

wincent avatar wincent commented on May 5, 2024

The thunk idea sounds reasonable on the surface.

As a workaround in the meantime @kamek-pf, you have a couple of options. One is just keeping everything that implements the interface in a single file (not great, obviously). The other: in a side project I ended up using a registration pattern to avoid the circular dependency issues.

from graphql-relay-js.

kevinSuttle avatar kevinSuttle commented on May 5, 2024

I think this is something that GraphQL-JS needs to address. I got stuck on a circular dependency the very first time I tried to implement an Interface. Perhaps it's a doc issue? There is currently very little documentation, and what's there is super confusing.

https://facebook.github.io/graphql/#sec-Interface-type-validation

The fields of an Interface type must have unique names within that Interface type; no two fields may share the same name.

Uh?

from graphql-relay-js.

kevinSuttle avatar kevinSuttle commented on May 5, 2024

@leebyron Would love to hear your thoughts on this, because it's both a GraphQL and a JavaScript issue, meaning, as soon as you try to circumvent the circular dependency by putting import statements into your resolveType: function, you get a syntax error in ES6. Using require then throws weird errors about outputType if you've followed the SWAPI implementation.

from graphql-relay-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.