Coder Social home page Coder Social logo

Comments (9)

leebyron avatar leebyron commented on May 3, 2024 1

I'd rather not optionalize it since that could be confusing for what works in one version of GraphiQL to not work elsewhere. Also, optionalizing by GraphiQL installation will just end up benefiting the author of the GraphiQL install rather than it's users.

Instead I think it makes sense to just have multiple key-combos that open the typeahead - basically any combo that's not already used for text editing is a viable candidate. That way if you have one of our multiple key-combos mapped to something else in your OS or browser that it can take precedence but there are always alternatives to use. This also means that we don't need to come to any consensus here, we can just add a couple reasonable ones.

How about cmd+space, alt+space, opt+space and shift+space all trigger typeahead? Are any of these commonly used by text inputs in any OS that would cause keeping all of these to be frustrating to use?

from graphiql.

lqez avatar lqez commented on May 3, 2024

👍

from graphiql.

eincs avatar eincs commented on May 3, 2024

👍

from graphiql.

leebyron avatar leebyron commented on May 3, 2024

I have no preference here since Cmd-Space is my habit from TextMate and Sublime. Those of you affected by this, what key combo do you use in other IDEs to trigger typeaheads/autocomplete?

from graphiql.

charypar avatar charypar commented on May 3, 2024

Would shift-space work as an alternative for people? I have both cmd-space and ctrl-space mapped in the OS

from graphiql.

leebyron avatar leebyron commented on May 3, 2024

I'm just curious what people use for auto-complete in IDEs when these keys are already mapped.

from graphiql.

asiandrummer avatar asiandrummer commented on May 3, 2024

Maybe we could optionalize the key mapping as well, unless there is a set of mappings popular to many people across. Shortcut key mapping as a prop in GraphiQL should be good enough.

from graphiql.

jamesroseman avatar jamesroseman commented on May 3, 2024

I'm a fan of this solution as well. The multiple options for universality feels right, and I agree with @leebyron when it comes to benefiting the author over benefiting the users. That said, Cmd + Space has been working fine for me.

from graphiql.

asiandrummer avatar asiandrummer commented on May 3, 2024

That way if you have one of our multiple key-combos mapped to something else in your OS or browser that it can take precedence but there are always alternatives to use.

I thought exactly the opposite was the case - sorry for the misunderstanding. Also agree with multiple options.

from graphiql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.