Comments (4)
Why did you close it without a reference nor a comment? @AlicanC provided some good info about connections setup, however this didn't answer the question, for me, at least.
from dataloader.
ideally you should not "loadAll", but have a connection which knows how to load each individually
check this: https://github.com/entria/graphql-mongoose-loader/blob/master/src/ConnectionFromMongoCursor.ts
from dataloader.
@jepezi do you mind please sharing your learnings here?
from dataloader.
On a root connection's resolve(), I just query the database for ids and return objects with only ids in them ([{ id: 1 }, { id: 2 }, ...]
) and then in resolveNode() (where I receive those objects) I load the rest of the data with DataLoader.
At first, making two trips to the database (one trip for ids and another batched trip for complete data) seemed stupid, but if the ids are cached then the second trip doesn't happen at all and if they are not cached then you are caching them for use in another query.
The function I use to create root connections look like this:
export function createRootConnectionField({ nodeType, tableName }) {
const { connectionType } = connectionDefinitions({
nodeType,
resolveNode: (edge) => getDataLoaderOfType(nodeType).load(edge.node.id),
connectionFields: () => ({
totalCount: {
type: GraphQLInt,
resolve: (connection) => connection.totalCount,
},
}),
});
return {
type: connectionType,
args: connectionArgs,
resolve: async (viewer, args) => {
const objects = await db(tableName).select('id');
return {
...connectionFromArray(objects, args),
totalCount: objects.count,
};
},
};
}
On the other hand, if your cache gets invalidated often, then you will be making two trips all the time and this becomes a performance issue. If that's the case then you could easily select all columns in resolve() and remove resolveNode(). If you do that, you might also want to prime the cache using dataLoader.prime(key, value) in your resolve().
from dataloader.
Related Issues (20)
- Move CI to GitHub Actions
- Setup publish token for CI
- Change default branch `master` to `main` HOT 1
- Setup Renovate Bot to keep dependencies up to date HOT 3
- [QUESTION] Why aren't keys being de-duplicated even when the cache is disabled? HOT 6
- ✨ [REQUEST]: Add examples for cacheKeyFn and cacheMap HOT 2
- [REQUEST]: How to pass auth headers to dataloader HOT 4
- [QUESTION] README.md doesn't show on npmjs.com HOT 2
- CacheMap.get calls should await the promised value HOT 1
- [QUESTION] Release changes? HOT 9
- [QUESTION] name is now required in options? HOT 4
- [BUG] Readme is missing from NPM HOT 2
- [BUG] `this` context not available in typescript definitions
- [BUG] Use caution with `jest.useFakeTimers()` HOT 1
- [REQUEST] support vercel edge functions by default HOT 4
- Ever considered the use of `queueMicrotask`? HOT 1
- Coalescing multiple load() calls HOT 3
- [REQUEST] Unify the way `load` and `loadMany` handle errors
- -
- [REQUEST] Add batch grouping
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dataloader.