DMMF dynamic require causing MODULE_NOT_FOUND about nexus-prisma

[jasonkuhrt]

Going to keep this open as a better version of #79.

The thing I want to fix is this:

On a side note, is there a reason prismaClientGenerator.output.value is generating an absolute path instead of passing a more flexible '@prisma/client' or relative paths?

I completely agree, and am not sure yet why this is happening.

You hit the issue on the head there @haleksandre, thanks!

[haleksandre]

I've updated & haven't reencouter the issue.

Thanks @jasonkuhrt!

[janpio]

What node version?
And the absolute folder being output is correct?

[haleksandre]

I've tried different version of node 12.x, 14.x & 16.x (I know 16.x isn't being tested yet but wanted to try) within docker containers.

12.x

Will fail to build altogether because of a typing issue.

I think NexusCore.ListDef<Post> should be NexusCore.NexusListDef<Post>

14.x & 16.x

Typing issue is still present but the build succeed & ./dist folder is generated with all lthe files from ./src

Then running node dist/server.js, in what ever node version (12.x, 14.x, 16.x) return the MODULE_NOT_FOUND error. The only way to make nexus-prisma find the package is by going into the node_modules/nexus-prisma/dist/helpers/prisma.js file explicitly put the string '@prisma/client' inside the require.

[haleksandre]

I fixed the issue & you were right about the absolute path so it was an issue on my side. Since I was running npm & node in seperate container with unknowly using different working directory for each. So the line below was outputting a different absolute path for @prisma/client in my npm container (generating/building) that my node container (running server) couldn't find.

https://github.com/prisma/nexus-prisma/blob/c8b5f6cd644ae3fa077d5a1b1678e637fee4ae07/src/cli/nexus-prisma.ts#L35

Thanks @janpi

On a side note, is there a reason prismaClientGenerator.output.value is generating an absolute path instead of passing a more flexible '@prisma/client' or relative paths?

This is causing problems when you mount the app files within different containers that doesn't necessarily have the same working directory.

[jasonkuhrt]

@haleksandre This is now fixed, or at least, a version of the problem.

If you can report back that would be great.

Thanks!